Migrate extension notifications to the new NotificationDisplayService

chrome/browser/notifications/notification_common.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_COMMON_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_COMMON_H_
 
 namespace content {
 class BrowserContext;
 }  // namespace content
 
 // Shared functionality for both in page and persistent notification
 class NotificationCommon {
  public:
   // Things as user can do to a notification.
+  // TODO(peter): Prefix these options with OPERATION_.

[Miguel Garcia, 2017/02/21 10:56:44]

FWIW we discussed this during the initial review and decided against it since it
seemed an overkill. Happy to revisit the decision again though.

[Peter Beverloo, 2017/02/21 17:23:50]

We didn't use the prefix when we used `enum classes`, which mean callers used:

  NotificationCommon::Operation::SETTINGS

Now that we switched back to regular enums as we use them as ints, callers now
use:

  NotificationCommon::SETTINGS

That conveys no information about what "settings" is. It's not a style guide
violation, but I do think it's much clearer. WDYT?

   enum Operation {
     CLICK = 0,
     CLOSE = 1,
     SETTINGS = 2,
     OPERATION_MAX = SETTINGS
   };
 
   // Possible kinds of notifications
+  // TODO(peter): Prefix these options with TYPE_.
   enum Type {
     PERSISTENT = 0,
     NON_PERSISTENT = 1,
-    TYPE_MAX = NON_PERSISTENT
+    EXTENSION = 2,
+    TYPE_MAX = EXTENSION
   };
 
   // Open the Notification settings screen when clicking the right button.
   // TODO(miguelg) have it take a Profile instead once NotificationObjectProxy
   // is updated.
   static void OpenNotificationSettings(
       content::BrowserContext* browser_context);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_COMMON_H_