Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 2703183002: Factor out gin::IsolateHolder's constructor
Patch Set: fix WorkerBackingThread Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
index 305bab8632d8c10ff2417c8c4d30df725a0ce13c..41e17fda64e5497c6b4147a59b8b0862784ba7e3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
@@ -47,7 +47,6 @@ class ActiveScriptWrappableBase;
class DOMDataStore;
class StringCache;
class V8PrivateProperty;
-class WebTaskRunner;
struct WrapperTypeInfo;
typedef WTF::Vector<DOMDataStore*> DOMDataStoreList;
@@ -97,7 +96,7 @@ class CORE_EXPORT V8PerIsolateData {
virtual ~Data() = default;
};
- static v8::Isolate* initialize(WebTaskRunner*);
+ static v8::Isolate* initialize(std::unique_ptr<gin::IsolateHolder>);
static V8PerIsolateData* from(v8::Isolate* isolate) {
ASSERT(isolate);
@@ -212,7 +211,7 @@ class CORE_EXPORT V8PerIsolateData {
}
private:
- explicit V8PerIsolateData(WebTaskRunner*);
+ explicit V8PerIsolateData(std::unique_ptr<gin::IsolateHolder>);
~V8PerIsolateData();
typedef HashMap<const void*, v8::Eternal<v8::FunctionTemplate>>

Powered by Google App Engine
This is Rietveld 408576698