Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2703013002: Ignore the |readonly| attribute in <input type=range> (Closed)

Created:
3 years, 10 months ago by Sunny
Modified:
3 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore the |readonly| attribute in <input type=range> Attribute |readonly| must be ignored in <input type=range> per spec [1] Test was changed accordingly [1] https://html.spec.whatwg.org/#range-state-(type=range) BUG=693037 Review-Url: https://codereview.chromium.org/2703013002 Cr-Commit-Position: refs/heads/master@{#451539} Committed: https://chromium.googlesource.com/chromium/src/+/9c948b9d9ed4d886e54f22a4a6705c9470213c09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/range/range-drag.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/range/range-drag-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sunny
Hi tkent@, PTAL, thanks~
3 years, 10 months ago (2017-02-18 14:20:04 UTC) #2
tkent
lgtm
3 years, 10 months ago (2017-02-20 00:52:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703013002/1
3 years, 10 months ago (2017-02-20 00:52:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 01:30:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c948b9d9ed4d886e54f22a4a670...

Powered by Google App Engine
This is Rietveld 408576698