Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp

Issue 2703013002: Ignore the |readonly| attribute in <input type=range> (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
index b9a47aa797eb0befce7a7975982bc811f732ee09..256d2b67600e97b0404b0688c81de1a371647380 100644
--- a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp
@@ -206,7 +206,7 @@ void SliderThumbElement::defaultEventHandler(Event* event) {
// Missing this kind of check is likely to occur elsewhere if adding it in
// each shadow element.
HTMLInputElement* input = hostInput();
- if (!input || input->isDisabledOrReadOnly()) {
+ if (!input || input->isDisabledFormControl()) {
stopDragging();
HTMLDivElement::defaultEventHandler(event);
return;
@@ -239,7 +239,7 @@ void SliderThumbElement::defaultEventHandler(Event* event) {
bool SliderThumbElement::willRespondToMouseMoveEvents() {
const HTMLInputElement* input = hostInput();
- if (input && !input->isDisabledOrReadOnly() && m_inDragMode)
+ if (input && !input->isDisabledFormControl() && m_inDragMode)
return true;
return HTMLDivElement::willRespondToMouseMoveEvents();
@@ -247,7 +247,7 @@ bool SliderThumbElement::willRespondToMouseMoveEvents() {
bool SliderThumbElement::willRespondToMouseClickEvents() {
const HTMLInputElement* input = hostInput();
- if (input && !input->isDisabledOrReadOnly())
+ if (input && !input->isDisabledFormControl())
return true;
return HTMLDivElement::willRespondToMouseClickEvents();
@@ -327,7 +327,7 @@ void SliderContainerElement::defaultEventHandler(Event* event) {
void SliderContainerElement::handleTouchEvent(TouchEvent* event) {
HTMLInputElement* input = hostInput();
- if (input->isDisabledOrReadOnly())
+ if (input->isDisabledFormControl())
return;
if (event->type() == EventTypeNames::touchend) {
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698