ios/chrome/browser/favicon/favicon_service_factory.cc - Issue 2703003002: Set null testing Favicon factories on iOS too

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/favicon/favicon_service_factory.cc

Issue 2703003002: Set null testing Favicon factories on iOS too (Closed)

Patch Set: Revert traces. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/favicon/favicon_service_factory.cc

diff --git a/ios/chrome/browser/favicon/favicon_service_factory.cc b/ios/chrome/browser/favicon/favicon_service_factory.cc

index 0c72fd5137fd740c757d1db9aa1a45d7c2ef8c47..2732a769c683a10663eb4449cd39ea889999b88c 100644

--- a/ios/chrome/browser/favicon/favicon_service_factory.cc

+++ b/ios/chrome/browser/favicon/favicon_service_factory.cc

@@ -58,4 +58,8 @@ std::unique_ptr<KeyedService> FaviconServiceFactory::BuildServiceInstanceFor(

browser_state, ServiceAccessType::EXPLICIT_ACCESS));

}

+bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const {

+ return true;

} // namespace ios