ios/chrome/browser/favicon/favicon_service_factory.h - Issue 2703003002: Set null testing Favicon factories on iOS too

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/favicon/favicon_service_factory.h

Issue 2703003002: Set null testing Favicon factories on iOS too (Closed)

Patch Set: Revert traces. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/favicon/favicon_service_factory.h

diff --git a/ios/chrome/browser/favicon/favicon_service_factory.h b/ios/chrome/browser/favicon/favicon_service_factory.h

index 8d81f8c2a4f55e38819bbd14b14209877c641302..dc8661debba0393e150978a02c1ffaf5598d9107 100644

--- a/ios/chrome/browser/favicon/favicon_service_factory.h

+++ b/ios/chrome/browser/favicon/favicon_service_factory.h

@@ -43,6 +43,7 @@ class FaviconServiceFactory : public BrowserStateKeyedServiceFactory {

// BrowserStateKeyedServiceFactory implementation.

std::unique_ptr<KeyedService> BuildServiceInstanceFor(

web::BrowserState* context) const override;

+ bool ServiceIsNULLWhileTesting() const override;

noyau (Ping after 24h) 2017/02/21 12:28:16 I hate things added to public APIs to use only for

mastiz 2017/02/21 12:37:10 Agreed :-/

DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);

};

« no previous file with comments | « no previous file | ios/chrome/browser/favicon/favicon_service_factory.cc » ('j') | no next file with comments »