ios/chrome/browser/favicon/favicon_service_factory.cc - Issue 2703003002: Set null testing Favicon factories on iOS too

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/favicon/favicon_service_factory.cc

Issue 2703003002: Set null testing Favicon factories on iOS too (Closed)

Patch Set: Revert traces. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/favicon/favicon_service_factory.h ('K') | « ios/chrome/browser/favicon/favicon_service_factory.h ('k') | ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ios/chrome/browser/favicon/favicon_service_factory.h"	5 #include "ios/chrome/browser/favicon/favicon_service_factory.h"

6	6

7 #include "base/memory/ptr_util.h"	7 #include "base/memory/ptr_util.h"

8 #include "base/memory/singleton.h"	8 #include "base/memory/singleton.h"

9 #include "components/favicon/core/favicon_service.h"	9 #include "components/favicon/core/favicon_service.h"

10 #include "components/keyed_service/core/service_access_type.h"	10 #include "components/keyed_service/core/service_access_type.h"

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 std::unique_ptr<KeyedService> FaviconServiceFactory::BuildServiceInstanceFor(	51 std::unique_ptr<KeyedService> FaviconServiceFactory::BuildServiceInstanceFor(

52 web::BrowserState* context) const {	52 web::BrowserState* context) const {

53 ios::ChromeBrowserState* browser_state =	53 ios::ChromeBrowserState* browser_state =

54 ios::ChromeBrowserState::FromBrowserState(context);	54 ios::ChromeBrowserState::FromBrowserState(context);

55 return base::MakeUnique<favicon::FaviconService>(	55 return base::MakeUnique<favicon::FaviconService>(

56 base::MakeUnique<FaviconClientImpl>(),	56 base::MakeUnique<FaviconClientImpl>(),

57 ios::HistoryServiceFactory::GetForBrowserState(	57 ios::HistoryServiceFactory::GetForBrowserState(

58 browser_state, ServiceAccessType::EXPLICIT_ACCESS));	58 browser_state, ServiceAccessType::EXPLICIT_ACCESS));

59 }	59 }

60	60

	61 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const {

	62 return true;

	63 }

	64

61 } // namespace ios	65 } // namespace ios

OLD	NEW