Add an end to end test: virtual keyboard opens on click of text input

Add an end to end test: virtual keyboard opens on click of text input

BUG=703488
TEST=try

Review-Url: https://codereview.chromium.org/2702933002
Cr-Commit-Position: refs/heads/master@{#458999}
Committed: https://chromium.googlesource.com/chromium/src/+/a55c4f37487521539106cea21457fbcd56afe68c

[oka, 2017-03-03 14:08:23]

.

[oka, 2017-03-20 23:40:00]

.

[oka, 2017-03-21 00:19:59]

.

[oka, 2017-03-21 03:33:31]

.

[oka, 2017-03-21 03:34:22]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 03:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-03-21 03:38:51]

.

[oka, 2017-03-21 03:40:58]

Description was changed from

==========
WIP. Add test.

BUG=
==========

to

==========
Add an end to end test: virtual keyboard opens on focus

BUG=
==========

[oka, 2017-03-21 03:44:01]

.

[oka, 2017-03-21 03:44:24]

Description was changed from

==========
Add an end to end test: virtual keyboard opens on focus

BUG=
==========

to

==========
Add an end to end test: virtual keyboard opens on focus

BUG=703488
TEST=try
==========

[oka, 2017-03-21 03:52:28]

oka@chromium.org changed reviewers:
+ bshe@chromium.org, jochen@chromium.org, oshima@chromium.org

[oka, 2017-03-21 03:54:42]

PTAL.

oshima@ for 
ash/test/BUILD.gn
chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc

jochen@ for chrome/test/*
bshe@ for ui/keyboard/*

CC: yhanada FYI.

[jochen (gone - plz use gerrit), 2017-03-21 10:31:05]

chrome/test/ lgtm

[oshima, 2017-03-21 14:57:57]

https://codereview.chromium.org/2702933002/diff/140001/ash/test/BUILD.gn
File ash/test/BUILD.gn (right):

https://codereview.chromium.org/2702933002/diff/140001/ash/test/BUILD.gn#newc...
ash/test/BUILD.gn:171: "//ui/keyboard:test_support",
why do you need this here? Shouldn't you add new to the browser test deps?

[oka, 2017-03-22 00:16:07]

Added dependency to ui/keyboard:test_support in browser_tests instead of a
target in ash/test/

[oka, 2017-03-22 00:18:32]

PTAL.

https://codereview.chromium.org/2702933002/diff/140001/ash/test/BUILD.gn
File ash/test/BUILD.gn (right):

https://codereview.chromium.org/2702933002/diff/140001/ash/test/BUILD.gn#newc...
ash/test/BUILD.gn:171: "//ui/keyboard:test_support",
On 2017/03/21 14:57:57, oshima wrote:
> why do you need this here? Shouldn't you add new to the browser test deps?

Reverted this file, and added the ui/keyboard:test_support to browser test deps.

[oka, 2017-03-22 20:22:57]

Friendly ping.

[bshe, 2017-03-22 20:36:44]

On 2017/03/22 20:22:57, oka wrote:
> Friendly ping.

lgtm

[oshima, 2017-03-22 21:03:44]

lgtm

https://codereview.chromium.org/2702933002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc (right):

https://codereview.chromium.org/2702933002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc:17: namespace {
nit: new line before after function

[oka, 2017-03-22 21:14:21]

https://codereview.chromium.org/2702933002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc (right):

https://codereview.chromium.org/2702933002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc:17: namespace {
On 2017/03/22 21:03:44, oshima wrote:
> nit: new line before after function

Done.

[oka, 2017-03-22 21:17:03]

.

[oka, 2017-03-23 02:19:48]

@bshe @oshima
Could you take another look? I've updated the test to simulate user's click on
elements.

[oka, 2017-03-23 02:21:02]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 02:21:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-03-23 02:26:30]

Description was changed from

==========
Add an end to end test: virtual keyboard opens on focus

BUG=703488
TEST=try
==========

to

==========
Add an end to end test: virtual keyboard opens on click of text input

BUG=703488
TEST=try
==========

[oka, 2017-03-23 02:26:43]

Description was changed from

==========
Add an end to end test: virtual keyboard opens on click of text input

BUG=703488
TEST=try
==========

to

==========
Add an end to end test: virtual keyboard opens on click of text input

BUG=703488
TEST=try
==========

[oshima, 2017-03-23 03:45:49]

slgtm

[commit-bot: I haz the power, 2017-03-23 03:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 03:52:24]

Dry run: This issue passed the CQ dry run.

[oka, 2017-03-23 04:05:38]

Thank you. Committing since ui/keyboard/* has no update.

[oka, 2017-03-23 04:05:44]

The CQ bit was checked by oka@chromium.org

[oka, 2017-03-23 04:05:45]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
oshima@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2702933002/#ps220001
(title: "Updated the test so to simulate user's click.")

[commit-bot: I haz the power, 2017-03-23 04:05:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 04:11:07]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1490241944521680,
"parent_rev": "e1a7452ea991283a3b83942348e0d2c35a34fea9", "commit_rev":
"a55c4f37487521539106cea21457fbcd56afe68c"}

[commit-bot: I haz the power, 2017-03-23 04:12:09]

Description was changed from

==========
Add an end to end test: virtual keyboard opens on click of text input

BUG=703488
TEST=try
==========

to

==========
Add an end to end test: virtual keyboard opens on click of text input

BUG=703488
TEST=try

Review-Url: https://codereview.chromium.org/2702933002
Cr-Commit-Position: refs/heads/master@{#458999}
Committed:
https://chromium.googlesource.com/chromium/src/+/a55c4f37487521539106cea21457...
==========

[commit-bot: I haz the power, 2017-03-23 04:12:11]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/a55c4f37487521539106cea21457...