Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 2702893002: Revert of Skip ARC initial screen when everything is set up by policy (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Skip ARC initial screen when everything is set up by policy (patchset #15 id:280001 of https://codereview.chromium.org/2682833003/ ) Reason for revert: Tentative revert for breaking RestoreOnStartupTestChromeOS.PRE_LogInAndVerify https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/22565 Original issue's description: > Skip ARC initial screen when everything is set up by policy > > Skip the ARC initial screen during provision when there is nothing > to be requested from the user on that screen, i.e. when the following > conditions are all true: > 1. ArcEnabled policy is set to true; > 2. ArcBackupRestoreEnabled policy is set to some value; > 3. ArcLocationServiceEnabled policy is set to some value. > > Note that the subsequent screen with the progress spinner will > also be hidden. This is the intended behavior - the UI feedback for > the user, if we decide to add it, will have to be implemented in a > different, less noisy for the user way. > > If some of the {ArcBackupRestoreEnabled;ArcLocationServiceEnabled} > policies become unset later, then the corresponding preferences will > change to the "false" state (which means that the user would have to > enable these features manually if they want to). > > BUG=690121 > BUG=b/34285262 > TEST=New unit and browser tests; > Manual test: enable ARC by policy, set ArcBackupRestoreEnabled > and ArcLocationServiceEnabled policies to some values, start > a fresh profile, check that ARC eventually gets provisioned > without showing any dialogs. > > Review-Url: https://codereview.chromium.org/2682833003 > Cr-Commit-Position: refs/heads/master@{#451340} > Committed: https://chromium.googlesource.com/chromium/src/+/1f0e3460633a614baa787c46a2c8031fc13c8dad TBR=yusukes@chromium.org,hidehiko@chromium.org,khmel@chromium.org,emaxx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=690121 Review-Url: https://codereview.chromium.org/2702893002 Cr-Commit-Position: refs/heads/master@{#451410} Committed: https://chromium.googlesource.com/chromium/src/+/28ad2a15159467d825c159b4f617b9f93383c725

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
alph
Created Revert of Skip ARC initial screen when everything is set up by policy
3 years, 10 months ago (2017-02-18 02:08:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702893002/1
3 years, 10 months ago (2017-02-18 02:10:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702893002/1
3 years, 10 months ago (2017-02-18 02:10:23 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 02:12:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28ad2a15159467d825c159b4f617...

Powered by Google App Engine
This is Rietveld 408576698