DescriptionRevert of Skip ARC initial screen when everything is set up by policy (patchset #15 id:280001 of https://codereview.chromium.org/2682833003/ )
Reason for revert:
Tentative revert for breaking RestoreOnStartupTestChromeOS.PRE_LogInAndVerify
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/22565
Original issue's description:
> Skip ARC initial screen when everything is set up by policy
>
> Skip the ARC initial screen during provision when there is nothing
> to be requested from the user on that screen, i.e. when the following
> conditions are all true:
> 1. ArcEnabled policy is set to true;
> 2. ArcBackupRestoreEnabled policy is set to some value;
> 3. ArcLocationServiceEnabled policy is set to some value.
>
> Note that the subsequent screen with the progress spinner will
> also be hidden. This is the intended behavior - the UI feedback for
> the user, if we decide to add it, will have to be implemented in a
> different, less noisy for the user way.
>
> If some of the {ArcBackupRestoreEnabled;ArcLocationServiceEnabled}
> policies become unset later, then the corresponding preferences will
> change to the "false" state (which means that the user would have to
> enable these features manually if they want to).
>
> BUG=690121
> BUG=b/34285262
> TEST=New unit and browser tests;
> Manual test: enable ARC by policy, set ArcBackupRestoreEnabled
> and ArcLocationServiceEnabled policies to some values, start
> a fresh profile, check that ARC eventually gets provisioned
> without showing any dialogs.
>
> Review-Url: https://codereview.chromium.org/2682833003
> Cr-Commit-Position: refs/heads/master@{#451340}
> Committed: https://chromium.googlesource.com/chromium/src/+/1f0e3460633a614baa787c46a2c8031fc13c8dad
TBR=yusukes@chromium.org,hidehiko@chromium.org,khmel@chromium.org,emaxx@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=690121
Review-Url: https://codereview.chromium.org/2702893002
Cr-Commit-Position: refs/heads/master@{#451410}
Committed: https://chromium.googlesource.com/chromium/src/+/28ad2a15159467d825c159b4f617b9f93383c725
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|