Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/chromeos/arc/arc_session_manager.cc

Issue 2702893002: Revert of Skip ARC initial screen when everything is set up by policy (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_session_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_session_manager.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.cc b/chrome/browser/chromeos/arc/arc_session_manager.cc
index 7eab36a63c72b086c0c29b6e9e06b531d7179912..6ae5cb9b46f27a2d3d58ec52a74577213bcac569 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager.cc
@@ -118,12 +118,8 @@
registry->RegisterBooleanPref(prefs::kArcEnabled, false);
registry->RegisterBooleanPref(prefs::kArcSignedIn, false);
registry->RegisterBooleanPref(prefs::kArcTermsAccepted, false);
- // Note that ArcBackupRestoreEnabled and ArcLocationServiceEnabled prefs have
- // to be off by default, until an explicit gesture from the user to enable
- // them is received. This is crucial in the cases when these prefs transition
- // from a previous managed state to the unmanaged.
- registry->RegisterBooleanPref(prefs::kArcBackupRestoreEnabled, false);
- registry->RegisterBooleanPref(prefs::kArcLocationServiceEnabled, false);
+ registry->RegisterBooleanPref(prefs::kArcBackupRestoreEnabled, true);
+ registry->RegisterBooleanPref(prefs::kArcLocationServiceEnabled, true);
}
// static
@@ -710,30 +706,18 @@
return;
}
- PrefService* const prefs = profile_->GetPrefs();
-
// For ARC Kiosk we skip ToS because it is very likely that near the device
// there will be no one who is eligible to accept them.
// TODO(poromov): Move to more Kiosk dedicated set-up phase.
if (IsArcKioskMode())
- prefs->SetBoolean(prefs::kArcTermsAccepted, true);
-
- // Skip to show UI asking users to enable/disable their preference for
- // backup-restore and location-service, if both are managed by the admin
- // policy. Note that the ToS agreement is anyway not shown in the case of the
- // managed ARC.
- if (IsArcManaged() &&
- prefs->IsManagedPreference(prefs::kArcBackupRestoreEnabled) &&
- prefs->IsManagedPreference(prefs::kArcLocationServiceEnabled)) {
- prefs->SetBoolean(prefs::kArcTermsAccepted, true);
- }
+ profile_->GetPrefs()->SetBoolean(prefs::kArcTermsAccepted, true);
// If it is marked that sign in has been successfully done, then directly
// start ARC.
- // For testing, and for Kiosk mode, we also skip ToS negotiation procedure.
+ // For testing, and for Kisok mode, we also skip ToS negotiation procedure.
// For backward compatibility, this check needs to be prior to the
// kArcTermsAccepted check below.
- if (prefs->GetBoolean(prefs::kArcSignedIn) ||
+ if (profile_->GetPrefs()->GetBoolean(prefs::kArcSignedIn) ||
IsArcOptInVerificationDisabled() || IsArcKioskMode()) {
StartArc();
@@ -767,12 +751,10 @@
// 1) User accepted the Terms of service on OOBE flow.
// 2) User accepted the Terms of service on Opt-in flow, but logged out
// before ARC sign in procedure was done. Then, logs in again.
- if (prefs->GetBoolean(prefs::kArcTermsAccepted)) {
+ if (profile_->GetPrefs()->GetBoolean(prefs::kArcTermsAccepted)) {
// Don't show UI for this progress if it was not shown.
- if (support_host_ &&
- support_host_->ui_page() != ArcSupportHost::UIPage::NO_PAGE) {
+ if (support_host_->ui_page() != ArcSupportHost::UIPage::NO_PAGE)
support_host_->ShowArcLoading();
- }
StartArcAndroidManagementCheck();
return;
}
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/arc_session_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698