vpython: Add primary execution package.

vpython: Add primary execution package.

Add the primary "vpython" execution package, which exports a set of
Options and a Run method. This implements the primary "vpython"
Python bootstrapping behavior.

BUG=chromium:691818
TEST=None

Review-Url: https://codereview.chromium.org/2702873002
Committed: https://github.com/luci/luci-go/commit/d98a0c6fa24f79922e5695de8905bd0f238c2948

[dnj, 2017-02-17 23:14:15]

Description was changed from

==========
Updated patchset dependency

vpython: Add primary execution package.

Add the primary "vpython" execution package, which exports a set of
Options and a Run method. This implements the primary "vpython"
Python bootstrapping behavior.

BUG=chromium:691818
TEST=None
==========

to

==========
vpython: Add primary execution package.

Add the primary "vpython" execution package, which exports a set of
Options and a Run method. This implements the primary "vpython"
Python bootstrapping behavior.

BUG=chromium:691818
TEST=None
==========

[dnj, 2017-02-17 23:17:53]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2017-02-17 23:17:54]

PTAL! This is part of a larger "vpython" CL set for the tool. More information
can be found in the bug, or in the linked design doc:
https://docs.google.com/document/d/1GKN7rtW6-006RbG_Ryh6vr4TpUxSxJlPSCKFLq2nO...

Total CL set is:
https://codereview.chromium.org/2703463006/ (README, protobufs)
https://codereview.chromium.org/2703793003/ (filesystem)
https://codereview.chromium.org/2700273002/ (wheel)
https://codereview.chromium.org/2705623003/ (environment spec)
https://codereview.chromium.org/2701073002/ (Python interpreter management)
https://codereview.chromium.org/2699063004/ (main VirtualEnv package)
https://codereview.chromium.org/2699223002/ (CIPD support)
https://codereview.chromium.org/2702873002/ (package entry point)
https://codereview.chromium.org/2705593003/ (main application)
https://chromium-review.googlesource.com/c/444040/ (Infra entry point)

[iannucci, 2017-02-23 02:15:40]

lgtm

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go
File vpython/options.go (right):

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go#newc...
vpython/options.go:88: // Additionally, track whether its a file or a module
(directory).
it's

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go#newc...
vpython/options.go:101: st, err := os.Stat(cmd.Value)
does s/Value/RunnableTarget make sense? or something like that? Value is vague.

Could also have ParseCommandLine return an interface and then type-switch
(ScriptCommandLine, ModuleCommandLine, InlineCommandLine)?

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go#newc...
vpython/options.go:145: logging.Infof(c, "Unable to resolve specification path.
Using empty specification.")
Warn?

[dnj, 2017-03-11 17:49:30]

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go
File vpython/options.go (right):

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go#newc...
vpython/options.go:88: // Additionally, track whether its a file or a module
(directory).
On 2017/02/23 02:15:40, iannucci wrote:
> it's

Done.

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go#newc...
vpython/options.go:101: st, err := os.Stat(cmd.Value)
On 2017/02/23 02:15:40, iannucci wrote:
> does s/Value/RunnableTarget make sense? or something like that? Value is
vague.
> 
> Could also have ParseCommandLine return an interface and then type-switch
> (ScriptCommandLine, ModuleCommandLine, InlineCommandLine)?

Changed to "Target", went with the type assertion idea.

https://codereview.chromium.org/2702873002/diff/40001/vpython/options.go#newc...
vpython/options.go:145: logging.Infof(c, "Unable to resolve specification path.
Using empty specification.")
On 2017/02/23 02:15:40, iannucci wrote:
> Warn?

Nah, no specification is totally legit, just means vanilla environment.

[dnj, 2017-03-11 18:01:27]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-03-11 18:01:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2702873002/#ps80001
(title: "more windows signals")

[commit-bot: I haz the power, 2017-03-11 18:01:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 18:14:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 18:14:07]

Try jobs failed on following builders:
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/34d76036f6bf2f10)

[dnj, 2017-03-11 18:24:57]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-03-11 18:25:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 18:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 18:37:38]

Try jobs failed on following builders:
  Luci-go Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/34d775917acb5810)

[dnj, 2017-03-11 18:51:40]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-03-11 18:51:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 18:58:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489258300278500,
"parent_rev": "e8e42efd50792c3df5e499cd6d1859f8943b6c16", "commit_rev":
"d98a0c6fa24f79922e5695de8905bd0f238c2948"}

[commit-bot: I haz the power, 2017-03-11 18:58:36]

Description was changed from

==========
vpython: Add primary execution package.

Add the primary "vpython" execution package, which exports a set of
Options and a Run method. This implements the primary "vpython"
Python bootstrapping behavior.

BUG=chromium:691818
TEST=None
==========

to

==========
vpython: Add primary execution package.

Add the primary "vpython" execution package, which exports a set of
Options and a Run method. This implements the primary "vpython"
Python bootstrapping behavior.

BUG=chromium:691818
TEST=None

Review-Url: https://codereview.chromium.org/2702873002
Committed:
https://github.com/luci/luci-go/commit/d98a0c6fa24f79922e5695de8905bd0f238c2948
==========

[commit-bot: I haz the power, 2017-03-11 18:58:37]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-go/commit/d98a0c6fa24f79922e5695de8905bd0f238c2948