vpython: Add application entry point.

vpython: Add application entry point.

Add the "vpython" application entry point. This pulls all of the various
vpython packages together into a single functional binary, which will be
the main Chrome Operations "vpython" interface.

BUG=chromium:691818
TEST=None

Review-Url: https://codereview.chromium.org/2705593003
Committed: https://github.com/luci/luci-go/commit/59ecc3c27fc9d5ef1e92c6eb845f928350e68d18

[dnj, 2017-02-17 23:14:22]

Description was changed from

==========
Updated patchset dependency

vpython: Add application entry point.

Add the "vpython" application entry point. This pulls all of the various
vpython packages together into a single functional binary, which will be
the main Chrome Operations "vpython" interface.

BUG=chromium:691818
TEST=None
==========

to

==========
vpython: Add application entry point.

Add the "vpython" application entry point. This pulls all of the various
vpython packages together into a single functional binary, which will be
the main Chrome Operations "vpython" interface.

BUG=chromium:691818
TEST=None
==========

[dnj, 2017-02-17 23:18:00]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org

[dnj, 2017-02-17 23:18:00]

PTAL! This is part of a larger "vpython" CL set for the tool. More information
can be found in the bug, or in the linked design doc:
https://docs.google.com/document/d/1GKN7rtW6-006RbG_Ryh6vr4TpUxSxJlPSCKFLq2nO...

Total CL set is:
https://codereview.chromium.org/2703463006/ (README, protobufs)
https://codereview.chromium.org/2703793003/ (filesystem)
https://codereview.chromium.org/2700273002/ (wheel)
https://codereview.chromium.org/2705623003/ (environment spec)
https://codereview.chromium.org/2701073002/ (Python interpreter management)
https://codereview.chromium.org/2699063004/ (main VirtualEnv package)
https://codereview.chromium.org/2699223002/ (CIPD support)
https://codereview.chromium.org/2702873002/ (package entry point)
https://codereview.chromium.org/2705593003/ (main application)
https://chromium-review.googlesource.com/c/444040/ (Infra entry point)

[iannucci, 2017-02-23 02:24:22]

lgtm

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
File vpython/application/application.go (right):

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:32: // An A is an application's default
configuration.
why not Config (e.g. application.Config) or Defaults (application.Defaults).

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:34: // PackageLoader is the package loader to
use.
no documented default values?

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:49: PruneLimit int
same comments as venv.Config about defaults and naming and such.

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:60: // Discard the entry Context and use the
one passed to us.
why? testing?

maybe docstring this func?

edit: oh, that's gnarly :(. We should really consider switching from subcommands
or making it truly nestable. Topic for another time I suppose.

[dnj, 2017-03-11 18:07:40]

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
File vpython/application/application.go (right):

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:32: // An A is an application's default
configuration.
On 2017/02/23 02:24:22, iannucci wrote:
> why not Config (e.g. application.Config) or Defaults (application.Defaults).

Made "Config".

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:34: // PackageLoader is the package loader to
use.
On 2017/02/23 02:24:22, iannucci wrote:
> no documented default values?

Nope, no default values at all!

The counterpart of this the main app entry point, which uses this package to
create defaults.

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:49: PruneLimit int
On 2017/02/23 02:24:22, iannucci wrote:
> same comments as venv.Config about defaults and naming and such.

Done.

https://codereview.chromium.org/2705593003/diff/1/vpython/application/applica...
vpython/application/application.go:60: // Discard the entry Context and use the
one passed to us.
On 2017/02/23 02:24:22, iannucci wrote:
> why? testing?
> 
> maybe docstring this func?
> 
> edit: oh, that's gnarly :(. We should really consider switching from
subcommands
> or making it truly nestable. Topic for another time I suppose.

OR... giving subcommands actual Context awareness instead of bolting it on, but
yes :)

[dnj, 2017-03-11 21:29:27]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-03-11 21:29:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2705593003/#ps40001
(title: "rebarse?")

[commit-bot: I haz the power, 2017-03-11 21:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 21:35:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489267767176630,
"parent_rev": "d98a0c6fa24f79922e5695de8905bd0f238c2948", "commit_rev":
"59ecc3c27fc9d5ef1e92c6eb845f928350e68d18"}

[commit-bot: I haz the power, 2017-03-11 21:35:35]

Description was changed from

==========
vpython: Add application entry point.

Add the "vpython" application entry point. This pulls all of the various
vpython packages together into a single functional binary, which will be
the main Chrome Operations "vpython" interface.

BUG=chromium:691818
TEST=None
==========

to

==========
vpython: Add application entry point.

Add the "vpython" application entry point. This pulls all of the various
vpython packages together into a single functional binary, which will be
the main Chrome Operations "vpython" interface.

BUG=chromium:691818
TEST=None

Review-Url: https://codereview.chromium.org/2705593003
Committed:
https://github.com/luci/luci-go/commit/59ecc3c27fc9d5ef1e92c6eb845f928350e68d18
==========

[commit-bot: I haz the power, 2017-03-11 21:35:36]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/59ecc3c27fc9d5ef1e92c6eb845f928350e68d18