Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2702853002: [LayoutNG] Shape items with context (Closed)

Created:
3 years, 10 months ago by eae
Modified:
3 years, 10 months ago
Reviewers:
kojii
CC:
ajuma+watch_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cbiesinger, chromium-reviews, danakj+watch_chromium.org, dgrogan+ng_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, glebl+reviews_chromium.org, jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, ojan+watch_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Shape items with context Change the inline-layout shaping approach in LayoutNG to shape each item with the full contetx of the NGInlineNode. BUG=689155 R=kojii@chromium.org Review-Url: https://codereview.chromium.org/2702853002 Cr-Commit-Position: refs/heads/master@{#451478} Committed: https://chromium.googlesource.com/chromium/src/+/3d591708efa7d967c4158fc03369a2bf11aeacc2

Patch Set 1 #

Patch Set 2 : Add null check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 2 chunks +12 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
eae
3 years, 10 months ago (2017-02-17 21:28:23 UTC) #1
kojii
lgtm
3 years, 10 months ago (2017-02-18 04:29:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702853002/20001
3 years, 10 months ago (2017-02-18 04:29:22 UTC) #12
commit-bot: I haz the power
Exceeded global retry quota
3 years, 10 months ago (2017-02-18 06:30:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702853002/20001
3 years, 10 months ago (2017-02-18 17:40:07 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 18:12:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d591708efa7d967c4158fc03369...

Powered by Google App Engine
This is Rietveld 408576698