third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h - Issue 2702853002: [LayoutNG] Shape items with context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

Issue 2702853002: [LayoutNG] Shape items with context (Closed)

Patch Set: Add null check Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

index 6dcb22d7321d233e8e0e0a7334cc6f66f2c34146..6079827a3ff9b0119ee61fe25564c426fe896a2d 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.h

@@ -51,14 +51,20 @@ class PLATFORM_EXPORT ShapeResultBuffer {

Vector<CharacterRange> individualCharacterRanges(TextDirection,

float totalWidth) const;

- static CharacterRange getCharacterRange(

+ static CharacterRange getCharacterRange(RefPtr<const ShapeResult>,

+ TextDirection,

+ float totalWidth,

+ unsigned from,

+ unsigned to);

+ private:

+ static CharacterRange getCharacterRangeInternal(

const Vector<RefPtr<const ShapeResult>, 64>&,

TextDirection,

float totalWidth,

unsigned from,

unsigned to);

- private:

float fillFastHorizontalGlyphBuffer(GlyphBuffer*, const TextRun&) const;

template <TextDirection>