Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2702803002: media-internals: Remove audio/video codec reporting from mp4 parser (Closed)

Created:
3 years, 10 months ago by xhwang
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, sandersd (OOO until July 31)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media-internals: Remove audio/video codec reporting from mp4 parser These parsers generated too many logs, most of which don't provide much value. When I watch youtube games channel, I can see new audio/video codec logs in media-internals every second. From the bug, it seems it'll take some more time before we have a proper fix. I think we should remove these logs for now, and then if needed, we can reenable them with the proper fix. BUG=653773 Review-Url: https://codereview.chromium.org/2702803002 Cr-Commit-Position: refs/heads/master@{#451421} Committed: https://chromium.googlesource.com/chromium/src/+/9c17e198a8ad64e0ca922329e701466f08161e6a

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -125 lines) Patch
M media/formats/mp4/aac.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/formats/mp4/aac_unittest.cc View 1 13 chunks +1 line, -68 lines 0 comments Download
M media/formats/mp4/box_definitions.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M media/formats/mp4/hevc.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser_unittest.cc View 1 17 chunks +0 lines, -37 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
xhwang
See bug update for why I am doing this... PTAL
3 years, 10 months ago (2017-02-17 18:52:51 UTC) #4
xhwang
sandersd: FYI
3 years, 10 months ago (2017-02-17 19:07:51 UTC) #5
DaleCurtis
lgtm
3 years, 10 months ago (2017-02-17 19:46:34 UTC) #8
wolenetz
lgtm % nit and updating the test expectations Please keep the bug alive for adding ...
3 years, 10 months ago (2017-02-17 19:48:38 UTC) #9
xhwang
https://codereview.chromium.org/2702803002/diff/1/media/formats/mp4/box_definitions.cc File media/formats/mp4/box_definitions.cc (right): https://codereview.chromium.org/2702803002/diff/1/media/formats/mp4/box_definitions.cc#newcode814 media/formats/mp4/box_definitions.cc:814: MEDIA_LOG(INFO, reader->media_log()) << "Audio codec: mp4a." << std::hex On ...
3 years, 10 months ago (2017-02-17 21:13:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702803002/20001
3 years, 10 months ago (2017-02-17 22:28:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
3 years, 10 months ago (2017-02-17 23:17:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702803002/20001
3 years, 10 months ago (2017-02-18 04:05:11 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 06:08:03 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c17e198a8ad64e0ca922329e701...

Powered by Google App Engine
This is Rietveld 408576698