Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: media/formats/mp4/box_definitions.cc

Issue 2702803002: media-internals: Remove audio/video codec reporting from mp4 parser (Closed)
Patch Set: comments addressed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp4/aac_unittest.cc ('k') | media/formats/mp4/hevc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/box_definitions.cc
diff --git a/media/formats/mp4/box_definitions.cc b/media/formats/mp4/box_definitions.cc
index b6ea088aff8abb45112a30c87a97ac779d58a3d2..558367e763a1d60e39e03b07e8c48b1ae5881387 100644
--- a/media/formats/mp4/box_definitions.cc
+++ b/media/formats/mp4/box_definitions.cc
@@ -610,11 +610,6 @@ bool AVCDecoderConfigurationRecord::ParseInternal(
RCHECK(reader->Read2(&sps_length) &&
reader->ReadVec(&sps_list[i], sps_length));
RCHECK(sps_list[i].size() > 4);
-
- if (media_log.get()) {
- MEDIA_LOG(INFO, media_log) << "Video codec: avc1."
- << base::HexEncode(sps_list[i].data() + 1, 3);
- }
}
uint8_t num_pps;
@@ -815,11 +810,6 @@ bool ElementaryStreamDescriptor::Parse(BoxReader* reader) {
object_type = es_desc.object_type();
- if (object_type != 0x40) {
- MEDIA_LOG(INFO, reader->media_log()) << "Audio codec: mp4a." << std::hex
- << static_cast<int>(object_type);
- }
-
if (es_desc.IsAAC(object_type))
RCHECK(aac.Parse(es_desc.decoder_specific_info(), reader->media_log()));
« no previous file with comments | « media/formats/mp4/aac_unittest.cc ('k') | media/formats/mp4/hevc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698