Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2702663002: [Merge to M57] cros-md: Remove the non-MD immersive mode code paths (Closed)

Created:
3 years, 10 months ago by Qiang(Joe) Xu
Modified:
3 years, 10 months ago
Reviewers:
tdanderson, sky
CC:
chromium-reviews, kalyank, miu+watch_chromium.org, sadrul, dcheng, tfarina
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge to M57] cros-md: Remove the non-MD immersive mode code paths Changes: Remove the non-MD immersive mode code paths TBR=tdanderson@chromium.org, sky@chromium.org BUG=690295 BUG=685831 TEST=emulator test, automation tests, also add test coverage Review-Url: https://codereview.chromium.org/2690443002 Cr-Commit-Position: refs/heads/master@{#451022} (cherry picked from commit f05f264d80c72ec2681cbd4b3854ab6ceceaee67) Review-Url: https://codereview.chromium.org/2702663002 . Cr-Commit-Position: refs/branch-heads/2987@{#567} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9a775b78d6cc7185af83e1095d6919505b3b7cba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -428 lines) Patch
M ash/common/material_design/material_design_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/common/material_design/material_design_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/common/shelf/shelf_layout_manager.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 8 chunks +18 lines, -52 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 7 chunks +13 lines, -27 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc View 6 chunks +15 lines, -36 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.h View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 8 chunks +3 lines, -57 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 7 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_stub.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 4 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 7 chunks +1 line, -100 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 4 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 6 chunks +4 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 10 months ago (2017-02-17 00:32:18 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9a775b78d6cc7185af83e1095d6919505b3b7cba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698