Issue 270263005: Use even rounding for better results when converting from scalar to fdot6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270263005: Use even rounding for better results when converting from scalar to fdot6 (Closed)

Created:
6 years, 7 months ago by gw280

Modified:
6 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com, gw

Base URL:
https://skia.googlesource.com/skia.git@neon

Visibility:
Public.

Use even rounding for better results when converting from scalar to fdot6 Originally from https://bugzilla.mozilla.org/show_bug.cgi?id=996108, patch by Jeff Muizelaar R=reed1 BUG=skia: Committed: https://skia.googlesource.com/skia/+/2f26528e59908856e36e88aa3be94d84014e9a58

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -0 lines)			Patch
M	src/core/SkEdge.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/core/SkEdge.cpp	View	1	5 chunks	+27 lines, -0 lines	0 comments	Download
M	src/core/SkFDot6.h	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

gw280

Did we ever conclude whether we should go down this route or not?

6 years, 6 months ago (2014-06-20 18:42:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/270263005/20001

6 years, 3 months ago (2014-08-29 15:40:44 UTC) #5

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 2f26528e59908856e36e88aa3be94d84014e9a58

6 years, 3 months ago (2014-08-29 15:48:03 UTC) #6

Message was sent while issue was closed.

Another test message