|
|
Descriptionwebkit_layout_tests: Add osmesa as data_dep.
osmesa is a "loadable module" object and hence needs to end up in the
data_deps file.
See content/shell:content_shell_crash_test for another example of this.
BUG=693002, 524758
NOTRY=true
Review-Url: https://codereview.chromium.org/2702613003
Cr-Commit-Position: refs/heads/master@{#451226}
Committed: https://chromium.googlesource.com/chromium/src/+/aac85d78a79fe653d913ad9278c18da28900a25b
Patch Set 1 #
Total comments: 1
Messages
Total messages: 26 (15 generated)
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Description was changed from ========== webkit_layout_tests: Add osmesa as data_dep. osmesa is a "loadable module" object and hence needs to end up in the data_deps file. See content/shell:content_shell_crash_test for another example of this. BUG=693002,524758 ========== to ========== webkit_layout_tests: Add osmesa as data_dep. osmesa is a "loadable module" object and hence needs to end up in the data_deps file. See content/shell:content_shell_crash_test for another example of this. BUG=693002,524758 ==========
tansell@chromium.org changed reviewers: + dpranke@google.com, jochen@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi! This patch should fix (or get us closer to) LayoutTests on swarming for the Mac builders. The error they are getting is; --------------------- 15:16:52.566 5262 [5298:771:0216/151652.444061:2246944496735:ERROR:gl_initializer_mac.cc(90)] osmesa.so not found at /b/swarm_slave/w/iryyXQcQ/out/Release/osmesa.so 15:16:52.566 5262 [5298:771:0216/151652.540598:2247041030049:ERROR:gl_initializer_mac.cc(90)] osmesa.so not found at /b/swarm_slave/w/iryyXQcQ/out/Release/osmesa.so --------------------- I'm unsure why Windows/Linux is not complaining about this file being missing too. I wonder if the base system is providing it? Tim 'mithro' Ansell
tansell@chromium.org changed reviewers: + jbudorick@chromium.org
Hi John, Looks like Dirk is OO today. Can you give me an LGTM for this CL? Tim 'mithro' Ansell
lgtm
The CQ bit was unchecked by tansell@chromium.org
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== webkit_layout_tests: Add osmesa as data_dep. osmesa is a "loadable module" object and hence needs to end up in the data_deps file. See content/shell:content_shell_crash_test for another example of this. BUG=693002,524758 ========== to ========== webkit_layout_tests: Add osmesa as data_dep. osmesa is a "loadable module" object and hence needs to end up in the data_deps file. See content/shell:content_shell_crash_test for another example of this. BUG=693002,524758 NOTRY=true ==========
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487306433533720, "parent_rev": "1d79a857fc39bc1e71c2e1ad523a9426a29fe14a", "commit_rev": "aac85d78a79fe653d913ad9278c18da28900a25b"}
Message was sent while issue was closed.
Description was changed from ========== webkit_layout_tests: Add osmesa as data_dep. osmesa is a "loadable module" object and hence needs to end up in the data_deps file. See content/shell:content_shell_crash_test for another example of this. BUG=693002,524758 NOTRY=true ========== to ========== webkit_layout_tests: Add osmesa as data_dep. osmesa is a "loadable module" object and hence needs to end up in the data_deps file. See content/shell:content_shell_crash_test for another example of this. BUG=693002,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2702613003 Cr-Commit-Position: refs/heads/master@{#451226} Committed: https://chromium.googlesource.com/chromium/src/+/aac85d78a79fe653d913ad9278c1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/aac85d78a79fe653d913ad9278c1...
Message was sent while issue was closed.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2702613003/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2702613003/diff/1/BUILD.gn#newcode933 BUILD.gn:933: "//third_party/mesa:osmesa", This doesn't seem right. Why would the layout tests themselves directly need this? And isn't this already listed as a data dependency of content_shell?
Message was sent while issue was closed.
On 2017/02/23 02:59:11, Dirk Pranke wrote: > https://codereview.chromium.org/2702613003/diff/1/BUILD.gn > File BUILD.gn (right): > > https://codereview.chromium.org/2702613003/diff/1/BUILD.gn#newcode933 > BUILD.gn:933: "//third_party/mesa:osmesa", > This doesn't seem right. Why would the layout tests themselves directly need > this? And isn't this already listed as a data dependency of content_shell? I don't quite understand /why/ this is needed but it definitely works. content/shell:content_shell_crash_test is another example of this happening. I think it might have to do with osmesa being a "loadable module"? Really need someone who understands GN better than I do to figure out what is going on here. I've logged https://crbug.com/695691 about this issue. Tim 'mithro' Ansell |