Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: BUILD.gn

Issue 2702613003: webkit_layout_tests: Add osmesa as data_dep. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 912 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 } 923 }
924 924
925 # This target contains only a small subset of the layout tests, 925 # This target contains only a small subset of the layout tests,
926 # and is useful for testing with the regular isolate mechanism. 926 # and is useful for testing with the regular isolate mechanism.
927 # To run the full layout test suite you need to use 927 # To run the full layout test suite you need to use
928 # :webkit_layout_tests_exparchive, above, instead. 928 # :webkit_layout_tests_exparchive, above, instead.
929 group("webkit_layout_tests") { 929 group("webkit_layout_tests") {
930 testonly = true 930 testonly = true
931 data_deps = [ 931 data_deps = [
932 "//content/shell:content_shell", 932 "//content/shell:content_shell",
933 "//third_party/mesa:osmesa",
Dirk Pranke 2017/02/23 02:59:11 This doesn't seem right. Why would the layout test
933 "//tools/imagediff", 934 "//tools/imagediff",
934 ] 935 ]
935 936
936 if (is_android) { 937 if (is_android) {
937 data_deps += [ 938 data_deps += [
938 "//breakpad:breakpad_unittests", 939 "//breakpad:breakpad_unittests",
939 "//breakpad:dump_syms", 940 "//breakpad:dump_syms",
940 "//breakpad:microdump_stackwalk", 941 "//breakpad:microdump_stackwalk",
941 "//breakpad:minidump_dump", 942 "//breakpad:minidump_dump",
942 "//breakpad:minidump_stackwalk", 943 "//breakpad:minidump_stackwalk",
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 assert(target_name != "") # Mark as used. 1102 assert(target_name != "") # Mark as used.
1102 sources = invoker.actual_sources 1103 sources = invoker.actual_sources
1103 assert( 1104 assert(
1104 sources == invoker.actual_sources, 1105 sources == invoker.actual_sources,
1105 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1106 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1106 } 1107 }
1107 1108
1108 assert_valid_out_dir("_unused") { 1109 assert_valid_out_dir("_unused") {
1109 actual_sources = [ "$root_build_dir/foo" ] 1110 actual_sources = [ "$root_build_dir/foo" ]
1110 } 1111 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698