Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2702603002: Mojo C++ bindings: remove unnecessary getters/params of AssociatedGroup. (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove unnecessary getters/params of AssociatedGroup. BUG=682334 Review-Url: https://codereview.chromium.org/2702603002 Cr-Commit-Position: refs/heads/master@{#451196} Committed: https://chromium.googlesource.com/chromium/src/+/c837a4d6c1a3aae42d2d536320d8ea38e83b7316

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -84 lines) Patch
M mojo/public/cpp/bindings/associated_binding.h View 4 chunks +2 lines, -10 lines 0 comments Download
M mojo/public/cpp/bindings/associated_group.h View 2 chunks +0 lines, -40 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/binding.h View 2 chunks +0 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 2 chunks +0 lines, -10 lines 0 comments Download
M mojo/public/cpp/bindings/lib/binding_state.h View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-16 21:45:27 UTC) #6
Ken Rockot(use gerrit already)
Deleting all the code LGTM!
3 years, 10 months ago (2017-02-16 21:47:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702603002/40001
3 years, 10 months ago (2017-02-16 23:19:09 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 02:43:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c837a4d6c1a3aae42d2d536320d8...

Powered by Google App Engine
This is Rietveld 408576698