Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2697033004: Mojo C++ bindings: remove usage of AssociatedGroup from ipc/ (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove usage of AssociatedGroup from ipc/ This class is now supposed to be used in bindings-internal code. Users don't have to know about it. BUG=682334 Review-Url: https://codereview.chromium.org/2697033004 Cr-Commit-Position: refs/heads/master@{#451134} Committed: https://chromium.googlesource.com/chromium/src/+/1aa8e56c3214410bfddf7a0c7552e1cd0824784e

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -47 lines) Patch
M ipc/ipc_channel.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M ipc/ipc_channel_mojo.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_mojo.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 6 chunks +2 lines, -13 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 3 chunks +1 line, -7 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (16 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-15 21:03:31 UTC) #3
Ken Rockot(use gerrit already)
LGTM! \o/
3 years, 10 months ago (2017-02-15 22:21:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697033004/60001
3 years, 10 months ago (2017-02-16 21:39:44 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 23:16:32 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1aa8e56c3214410bfddf7a0c7552...

Powered by Google App Engine
This is Rietveld 408576698