Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2702583004:
win: Don't pass /guard:cf to lld for now (Closed)
Descriptionwin: Don't pass /guard:cf to lld for now
It doesn't understand the flag yet.
BUG=693709
NOTRY=true
Review-Url: https://codereview.chromium.org/2702583004
Cr-Commit-Position: refs/heads/master@{#451867}
Committed: https://chromium.googlesource.com/chromium/src/+/390d2eb8431b01a37bd96831ab8ee210fd73bdcb
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + pennymac@chromium.org
(our fyi clang+lld bots are red because of this; else not very important)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/17 20:43:50, Nico wrote: > (our fyi clang+lld bots are red because of this; else not very important) Oh, I didn't realize we had any LLD bots yet! Looks good to me - but I'm not an owner of this file. Might want to add scottmg@. LGTM
I'm an owner, your lgtm is all I need :-) Thanks!
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/17 21:19:29, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Ah yes, that helps! :D
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== win: Don't pass /guard:cf to lld for now It doesn't understand the flag yet. BUG=693709 ========== to ========== win: Don't pass /guard:cf to lld for now It doesn't understand the flag yet. BUG=693709 NOTRY=true ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487719549748360, "parent_rev":
"21a89764bf8243494e3cb6f19096444bb7b9d6ed", "commit_rev":
"390d2eb8431b01a37bd96831ab8ee210fd73bdcb"}
Message was sent while issue was closed.
Description was changed from ========== win: Don't pass /guard:cf to lld for now It doesn't understand the flag yet. BUG=693709 NOTRY=true ========== to ========== win: Don't pass /guard:cf to lld for now It doesn't understand the flag yet. BUG=693709 NOTRY=true Review-Url: https://codereview.chromium.org/2702583004 Cr-Commit-Position: refs/heads/master@{#451867} Committed: https://chromium.googlesource.com/chromium/src/+/390d2eb8431b01a37bd96831ab8e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/390d2eb8431b01a37bd96831ab8e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
