Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: build/config/win/BUILD.gn

Issue 2702583004: win: Don't pass /guard:cf to lld for now (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index a7db829cd6b1bc33b5f81917f905f40927067b5c..5e1f7fcc4d83dc25ef571b9490445f8c59c54db8 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -256,7 +256,8 @@ config("common_linker_setup") {
# https://msdn.microsoft.com/en-us/library/windows/desktop/mt637065.aspx
# /DYNAMICBASE (ASLR) is turned off in debug builds, therefore CFG can’t be
# turned on either.
- if (!is_debug) {
+ # TODO(thakis): Turn this on with lld once supported, https://crbug.com/693709
+ if (!is_debug && !use_lld) {
# Turn on CFG in msvc linker, regardless of compiler used.
ldflags += [ "/guard:cf" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698