DevTools: do not assign empty content to CSS UISourceCode in case of protocol error

DevTools: do not assign empty content to CSS UISourceCode in case of protocol error

This patch removes an outdated logic which was assigning empty content
to CSS UISourceCodes in case of protocol error.

BUG=687360
R=dgozman

Review-Url: https://codereview.chromium.org/2702583003
Cr-Commit-Position: refs/heads/master@{#451423}
Committed: https://chromium.googlesource.com/chromium/src/+/200c7f1b24cac1345bfed596d5ba961bc993c63a

[lushnikov, 2017-02-17 00:02:27]

please, take a look

[lushnikov, 2017-02-17 00:02:32]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 00:05:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-02-17 01:09:27]

Let's have a test:
- setup a css file with persistence;
- issue and edit command to it;
- synchronously evaluate code which removes the stylesheet;
- observer the non-empty content in a file.

[commit-bot: I haz the power, 2017-02-17 02:58:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:58:10]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-02-17 19:30:43]

added a test, please take another loo

[lushnikov, 2017-02-17 19:30:48]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:31:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-02-17 19:33:30]

Nice! lgtm

[lushnikov, 2017-02-17 19:34:12]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-02-17 19:34:12]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:34:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:31:18]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[lushnikov, 2017-02-17 22:16:34]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:16:59]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:43:56]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:43:57]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2702583003/#ps40001
(title: "fix test")

[lushnikov, 2017-02-17 22:43:58]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:43:58]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:43:59]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:43:59]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:43:59]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-02-18 00:19:18]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:20:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:20:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-02-18 03:03:54]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 06:15:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487387034055260,
"parent_rev": "c19fca96fd84744f90a81c8b75d9c6a4a43cf1b8", "commit_rev":
"200c7f1b24cac1345bfed596d5ba961bc993c63a"}

[commit-bot: I haz the power, 2017-02-18 06:16:47]

Description was changed from

==========
DevTools: do not assign empty content to CSS UISourceCode in case of protocol
error

This patch removes an outdated logic which was assigning empty content
to CSS UISourceCodes in case of protocol error.

BUG=687360
R=dgozman
==========

to

==========
DevTools: do not assign empty content to CSS UISourceCode in case of protocol
error

This patch removes an outdated logic which was assigning empty content
to CSS UISourceCodes in case of protocol error.

BUG=687360
R=dgozman

Review-Url: https://codereview.chromium.org/2702583003
Cr-Commit-Position: refs/heads/master@{#451423}
Committed:
https://chromium.googlesource.com/chromium/src/+/200c7f1b24cac1345bfed596d5ba...
==========

[commit-bot: I haz the power, 2017-02-18 06:16:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/200c7f1b24cac1345bfed596d5ba...