third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js - Issue 2702583003: DevTools: do not assign empty content to CSS UISourceCode in case of protocol error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

Issue 2702583003: DevTools: do not assign empty content to CSS UISourceCode in case of protocol error (Closed)

Patch Set: fix test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-overwrite-css-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

index 49cb560acdc6cfcf0a820d99581a6e6968d0192a..ede1cdd25fc0578f8c770f5723b6a54013314086 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

@@ -269,11 +269,15 @@ Bindings.StylesSourceMapping = class {

function callback(uiSourceCode, content) {

var styleFile = this._styleFiles.get(uiSourceCode);

- if (styleFile)

- styleFile.addRevision(content || '');

+ if (typeof content === 'string' && styleFile)

+ styleFile.addRevision(content);

+ this._styleFileSyncedForTest();

}

+ _styleFileSyncedForTest() {

+ }

dispose() {

Common.EventTarget.removeEventListeners(this._eventListeners);

}