Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2702523003: [DevTools] Continue GlassPane refactoring. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Continue GlassPane refactoring. - turned it into Widget, which allows to show widget inside of it properly; - removed extra layering in Dialog; - improved performance by reducing the number of relayouts; - easier API for GlassPane/Dialog; - fixed Document.deepElementFromPoint returning null for elements containing UA shadow root. BUG=none Review-Url: https://codereview.chromium.org/2702523003 Cr-Commit-Position: refs/heads/master@{#451523} Committed: https://chromium.googlesource.com/chromium/src/+/3e3774f369e1e642d06e895276b08814b279c20c

Patch Set 1 #

Patch Set 2 : works #

Patch Set 3 : element #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -227 lines) Patch
M third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid.html View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/dom_extension/DOMExtension.js View 1 chunk +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js View 1 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js View 1 4 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 1 2 4 chunks +17 lines, -96 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 1 8 chunks +84 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 5 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 2 3 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/dialog.css View 1 1 chunk +2 lines, -17 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/ui/glassPane.css View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (17 generated)
dgozman
Could you please take a look?
3 years, 10 months ago (2017-02-17 21:39:51 UTC) #9
pfeldman
lgtm, but please pass element instead of the document into show.
3 years, 10 months ago (2017-02-17 21:48:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702523003/40001
3 years, 10 months ago (2017-02-19 07:11:58 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/235410)
3 years, 10 months ago (2017-02-19 09:02:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702523003/40001
3 years, 10 months ago (2017-02-19 16:21:20 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-19 16:52:46 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e3774f369e1e642d06e895276b0...

Powered by Google App Engine
This is Rietveld 408576698