Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js

Issue 2702523003: [DevTools] Continue GlassPane refactoring. (Closed)
Patch Set: element Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
index e0dfe627d834137740414efaaa038007529be8d0..983ceebae31c0223b2fda97b05ac44f5607f8eaf 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
@@ -123,8 +123,9 @@ UI.Toolbar = class {
var document = button.element.ownerDocument;
document.documentElement.addEventListener('mouseup', mouseUp, false);
- var optionsGlassPane = new UI.GlassPane(document, false /* dimmed */, true /* blockPointerEvents */, event => {});
- optionsGlassPane.show();
+ var optionsGlassPane = new UI.GlassPane();
+ optionsGlassPane.setBlockPointerEvents(true);
+ optionsGlassPane.showGlassPane(document);
var optionsBar = new UI.Toolbar('fill', optionsGlassPane.contentElement);
optionsBar._contentElement.classList.add('floating');
const buttonHeight = 26;
@@ -168,7 +169,7 @@ UI.Toolbar = class {
function mouseUp(e) {
if (e.which !== 1)
return;
- optionsGlassPane.hide();
+ optionsGlassPane.hideGlassPane();
document.documentElement.removeEventListener('mouseup', mouseUp, false);
for (var i = 0; i < buttons.length; ++i) {

Powered by Google App Engine
This is Rietveld 408576698