Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2702413004: Revert "ViewRoot class for event forwarding on Android" (Closed)

Created:
3 years, 10 months ago by Jinsuk Kim
Modified:
3 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "ViewRoot class for event forwarding on Android" Will take other approach based on per-content EventHandler for now. This reverts commit a3d353091d8189530b26c905d6fb688b333fc819. BUG=671401 Review-Url: https://codereview.chromium.org/2702413004 Cr-Commit-Position: refs/heads/master@{#452239} Committed: https://chromium.googlesource.com/chromium/src/+/51d9be7fe7e02868cce6ce9794f973e4a3279cd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -794 lines) Patch
M ui/android/BUILD.gn View 4 chunks +0 lines, -7 lines 0 comments Download
D ui/android/java/src/org/chromium/ui/base/ViewRoot.java View 1 chunk +0 lines, -104 lines 0 comments Download
M ui/android/ui_android_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/android/view_android.h View 6 chunks +5 lines, -35 lines 0 comments Download
M ui/android/view_android.cc View 5 chunks +13 lines, -70 lines 0 comments Download
D ui/android/view_android_unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D ui/android/view_client.h View 1 chunk +0 lines, -103 lines 0 comments Download
D ui/android/view_client.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D ui/android/view_root.h View 1 chunk +0 lines, -71 lines 0 comments Download
D ui/android/view_root.cc View 1 chunk +0 lines, -106 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Jinsuk Kim
3 years, 10 months ago (2017-02-22 00:53:31 UTC) #6
boliu
rs lgtm assuming no conflicts? I didn't actually look..
3 years, 10 months ago (2017-02-22 01:20:14 UTC) #7
Jinsuk Kim
On 2017/02/22 01:20:14, boliu wrote: > rs lgtm assuming no conflicts? I didn't actually look.. ...
3 years, 10 months ago (2017-02-22 01:24:29 UTC) #8
boliu
On 2017/02/22 01:24:29, Jinsuk Kim wrote: > On 2017/02/22 01:20:14, boliu wrote: > > rs ...
3 years, 10 months ago (2017-02-22 01:25:06 UTC) #9
Jinsuk Kim
On 2017/02/22 01:25:06, boliu wrote: > On 2017/02/22 01:24:29, Jinsuk Kim wrote: > > On ...
3 years, 10 months ago (2017-02-22 01:28:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2702413004/1
3 years, 10 months ago (2017-02-22 22:28:51 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 22:36:07 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51d9be7fe7e02868cce6ce9794f9...

Powered by Google App Engine
This is Rietveld 408576698