Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: ui/android/view_android.h

Issue 2702413004: Revert "ViewRoot class for event forwarding on Android" (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/ui_android_jni_registrar.cc ('k') | ui/android/view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/view_android.h
diff --git a/ui/android/view_android.h b/ui/android/view_android.h
index e446048580dc6d63d456cff04791170fa19bfccc..68adf34d70eb8e6496ff37e547b165eb5bcc4d98 100644
--- a/ui/android/view_android.h
+++ b/ui/android/view_android.h
@@ -10,7 +10,6 @@
#include "base/android/jni_weak_ref.h"
#include "base/memory/ref_counted.h"
#include "ui/android/ui_android_export.h"
-#include "ui/android/view_client.h"
#include "ui/gfx/geometry/rect_f.h"
namespace cc {
@@ -23,8 +22,6 @@ class WindowAndroid;
// A simple container for a UI layer.
// At the root of the hierarchy is a WindowAndroid, when attached.
-// TODO(jinsukkim): Replace WindowAndroid with ViewRoot for the root of the
-// view hierarchy. See https://crbug.com/671401
class UI_ANDROID_EXPORT ViewAndroid {
public:
// Stores an anchored view to delete itself at the end of its lifetime
@@ -57,7 +54,9 @@ class UI_ANDROID_EXPORT ViewAndroid {
// Default copy/assign disabled by move constructor.
};
- explicit ViewAndroid(ViewClient* client);
+ // A ViewAndroid may have its own delegate or otherwise will
+ // use the next available parent's delegate.
+ ViewAndroid(const base::android::JavaRef<jobject>& delegate);
ViewAndroid();
virtual ~ViewAndroid();
@@ -76,29 +75,18 @@ class UI_ANDROID_EXPORT ViewAndroid {
// if disconnected.
virtual WindowAndroid* GetWindowAndroid() const;
- // Returns |ViewRoot| of this hierarchy. |null| if the hierarchy isn't
- // attached to a |ViewRoot|.
- virtual ViewAndroid* GetViewRoot();
-
// Used to return and set the layer for this view. May be |null|.
cc::Layer* GetLayer() const;
void SetLayer(scoped_refptr<cc::Layer> layer);
void SetDelegate(const base::android::JavaRef<jobject>& delegate);
- // Adds a child to this view.
+ // Adds this view as a child of another view.
void AddChild(ViewAndroid* child);
- // Move the give child ViewAndroid to the top of the list
- // so that it can be the first responder of events.
- void MoveToTop(ViewAndroid* child);
-
// Detaches this view from its parent.
void RemoveFromParent();
- // Set the layout relative to parent. Used to do hit testing against events.
- void SetLayout(int x, int y, int width, int height, bool match_parent);
-
bool StartDragAndDrop(const base::android::JavaRef<jstring>& jtext,
const base::android::JavaRef<jobject>& jimage);
@@ -110,18 +98,9 @@ class UI_ANDROID_EXPORT ViewAndroid {
base::android::ScopedJavaLocalRef<jobject> GetContainerView();
protected:
- // Internal implementation of ViewClient forwarding calls to the interface.
- bool OnTouchEventInternal(const MotionEventData& event);
-
- // Virtual for testing.
- virtual float GetDipScale();
-
ViewAndroid* parent_;
private:
- // Returns true only if this is of type |ViewRoot|.
- bool IsViewRoot();
-
void RemoveChild(ViewAndroid* child);
// Returns the Java delegate for this view. This is used to delegate work
@@ -130,19 +109,10 @@ class UI_ANDROID_EXPORT ViewAndroid {
const base::android::ScopedJavaLocalRef<jobject>
GetViewAndroidDelegate() const;
- // The child view at the back of the list receives event first.
std::list<ViewAndroid*> children_;
scoped_refptr<cc::Layer> layer_;
JavaObjectWeakGlobalRef delegate_;
- ViewClient* const client_;
-
- // Basic view layout information. Used to do hit testing deciding whether
- // the passed events should be processed by the view.
- gfx::Point origin_; // In parent's coordinate space.
- gfx::Size size_;
- bool match_parent_; // Bounds matches that of the parent if true.
-
- gfx::Vector2dF content_offset_; // In CSS pixel.
+ gfx::Vector2dF content_offset_; // in CSS pixel
DISALLOW_COPY_AND_ASSIGN(ViewAndroid);
};
« no previous file with comments | « ui/android/ui_android_jni_registrar.cc ('k') | ui/android/view_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698