Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 270233002: extensions: Remove dependency on chrome's common target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Cook
Visibility:
Public.

Description

extensions: Remove dependency on chrome's common target. Now that installer does not need extensions' constant (removed in r268166) we can finally build constants.* within extensions_common target. BUG=368334 TEST=green trybots R=yoz@chromium.org TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/common_constants.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 7 months ago (2014-05-07 03:16:01 UTC) #1
Yoyo Zhou
LGTM
6 years, 7 months ago (2014-05-07 20:07:33 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 7 months ago (2014-05-07 20:07:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/270233002/1
6 years, 7 months ago (2014-05-07 20:15:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 20:41:55 UTC) #5
tfarina
TBRing Lei for chrome/ changes...
6 years, 7 months ago (2014-05-07 20:44:56 UTC) #6
Lei Zhang
lgtm
6 years, 7 months ago (2014-05-07 20:52:31 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 21:47:51 UTC) #8
Message was sent while issue was closed.
Change committed as 268968

Powered by Google App Engine
This is Rietveld 408576698