Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: extensions/extensions.gyp

Issue 270233002: extensions: Remove dependency on chrome's common target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common_constants.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/extensions.gyp
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
index faaa42bcf556b1e854137ea71f54cb98016a50a2..77bbd6acaaf5d5f668084b796f8798c00a7f9e9a 100644
--- a/extensions/extensions.gyp
+++ b/extensions/extensions.gyp
@@ -15,9 +15,6 @@
# api resources compiled into the chrome resource bundle.
# http://crbug.com/162530
'../chrome/chrome_resources.gyp:chrome_resources',
- # TODO(tfarina): This dep here is for extensions/common/constants.*
- # We should find a way to compile this module within extensions_common.
- '../chrome/common_constants.gyp:common_constants',
'../components/components.gyp:url_matcher',
'../content/content.gyp:content_common',
'../crypto/crypto.gyp:crypto',
@@ -46,6 +43,8 @@
'common/api/sockets/sockets_manifest_permission.h',
'common/common_manifest_handlers.cc',
'common/common_manifest_handlers.h',
+ 'common/constants.cc',
+ 'common/constants.h',
'common/crx_file.cc',
'common/crx_file.h',
'common/csp_validator.cc',
« no previous file with comments | « chrome/common_constants.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698