extensions: Remove dependency on chrome's common target.

extensions/extensions.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
       'target_name': 'extensions_common',
       'type': 'static_library',
       'dependencies': [
         # TODO(benwells): figure out what to do with the api target and
         # api resources compiled into the chrome resource bundle.
         # http://crbug.com/162530
         '../chrome/chrome_resources.gyp:chrome_resources',
-        # TODO(tfarina): This dep here is for extensions/common/constants.*
-        # We should find a way to compile this module within extensions_common.
-        '../chrome/common_constants.gyp:common_constants',
         '../components/components.gyp:url_matcher',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
         '../ipc/ipc.gyp:ipc',
         '../net/net.gyp:net',
         '../third_party/re2/re2.gyp:re2',
         '../ui/base/ui_base.gyp:ui_base',
         '../ui/gfx/gfx.gyp:gfx_geometry',
         '../url/url.gyp:url_lib',
         'common/api/api.gyp:extensions_api',
         'extensions_strings.gyp:extensions_strings',
       ],
       'include_dirs': [
         '..',
         '<(INTERMEDIATE_DIR)',
       ],
       'sources': [
         'common/ad_injection_constants.cc',
         'common/ad_injection_constants.h',
         'common/api/messaging/message.h',
         'common/api/sockets/sockets_manifest_data.cc',
         'common/api/sockets/sockets_manifest_data.h',
         'common/api/sockets/sockets_manifest_handler.cc',
         'common/api/sockets/sockets_manifest_handler.h',
         'common/api/sockets/sockets_manifest_permission.cc',
         'common/api/sockets/sockets_manifest_permission.h',
         'common/common_manifest_handlers.cc',
         'common/common_manifest_handlers.h',
+        'common/constants.cc',
+        'common/constants.h',
         'common/crx_file.cc',
         'common/crx_file.h',
         'common/csp_validator.cc',
         'common/csp_validator.h',
         'common/dom_action_types.h',
         'common/draggable_region.cc',
         'common/draggable_region.h',
         'common/error_utils.cc',
         'common/error_utils.h',
         'common/event_filter.cc',
@@ skipping 542 matching lines @@
         'test/test_extensions_client.cc',
         'test/test_extensions_client.h',
         'test/test_permission_message_provider.cc',
         'test/test_permission_message_provider.h',
         'test/test_permissions_provider.cc',
         'test/test_permissions_provider.h',
       ],
     },
   ]
 }