third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebased upto r451733 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h

diff --git a/third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h b/third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h

index 5cb907972b0a7f83f55039c8ac81d1e5ed1d52fb..1547841b94ed21f3b9391dc72f7bbad7ad52ee1c 100644

--- a/third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h

+++ b/third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h

@@ -69,7 +69,11 @@ class PLATFORM_EXPORT WebScrollbarImpl final : public WebScrollbar {

private:

explicit WebScrollbarImpl(Scrollbar*);

- Persistent<Scrollbar> m_scrollbar;

+ // Accessed by main and compositor threads, e.g., the compositor thread

+ // checks |orientation()|.

+ //

+ // TODO: minimize or avoid cross-thread use, if possible.

+ CrossThreadPersistent<Scrollbar> m_scrollbar;

};

} // namespace blink