third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebased upto r451733 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/PannerNode.h ('k') | third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 WebScrollbarOverlayColorTheme scrollbarOverlayColorTheme() const override;	62 WebScrollbarOverlayColorTheme scrollbarOverlayColorTheme() const override;

63 bool isCustomScrollbar() const override;	63 bool isCustomScrollbar() const override;

64 Orientation orientation() const override;	64 Orientation orientation() const override;

65 bool isLeftSideVerticalScrollbar() const override;	65 bool isLeftSideVerticalScrollbar() const override;

66 float elasticOverscroll() const override;	66 float elasticOverscroll() const override;

67 void setElasticOverscroll(float) override;	67 void setElasticOverscroll(float) override;

68	68

69 private:	69 private:

70 explicit WebScrollbarImpl(Scrollbar*);	70 explicit WebScrollbarImpl(Scrollbar*);

71	71

72 Persistent<Scrollbar> m_scrollbar;	72 // Accessed by main and compositor threads, e.g., the compositor thread

	73 // checks \|orientation()\|.

	74 //

	75 // TODO: minimize or avoid cross-thread use, if possible.

	76 CrossThreadPersistent<Scrollbar> m_scrollbar;

73 };	77 };

74	78

75 } // namespace blink	79 } // namespace blink

76	80

77 #endif	81 #endif

OLD	NEW