third_party/WebKit/Source/modules/webaudio/PannerNode.h - Issue 2702243003: Disallow cross-thread Persistent<> read access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.h

Issue 2702243003: Disallow cross-thread Persistent<> read access. (Closed)

Patch Set: rebased upto r451733 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/PannerNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.h b/third_party/WebKit/Source/modules/webaudio/PannerNode.h

index 8d90c8a960e243d6c7bd6b506410899e085efe10..7e2a1f90ea2bf8a20ef9ef4023bb750d541782ef 100644

--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.h

@@ -158,8 +158,8 @@ class PannerHandler final : public AudioHandler {

void updateDirtyState();

// This Persistent doesn't make a reference cycle including the owner

- // PannerNode.

- Persistent<AudioListener> m_listener;

+ // PannerNode. It is accessed by both audio and main thread.

+ CrossThreadPersistent<AudioListener> m_listener;

std::unique_ptr<Panner> m_panner;

unsigned m_panningModel;

unsigned m_distanceModel;