Incl. custom properties in CSS property UseCounter

Incl. custom properties in CSS property UseCounter

The CSS property UseCounter records which CSS properties are used on
each page. Custom CSS properties were not included. This patch adds a
call to the CSS property UseCounter::count method to the parsing code
for custom properties.

Note that
- all custom CSS properties are grouped together with the ID
  CSSPropertyVariable, and
- the BitVector used by the UseCounter is already large enough to
  include this data; the DCHECK in the count method just needs to be
  extended to allow the CSSPropertyVariable ID value.

BUG=458925
Review-Url: https://codereview.chromium.org/2702183002
Cr-Commit-Position: refs/heads/master@{#456000}
Committed: https://chromium.googlesource.com/chromium/src/+/ca5b55100d024fb5b6ed95e9ad3fcb1d1ae24462

[suzyh_UTC10 (ex-contributor), 2017-02-20 05:28:03]

suzyh@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2017-02-20 06:27:20]

On 2017/02/20 05:28:12, suzyh wrote:

lgtm

[suzyh_UTC10 (ex-contributor), 2017-02-20 22:42:39]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-02-20 22:42:44]

The CQ bit was unchecked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-02-21 00:21:35]

On 2017/02/20 at 06:27:20, timloh wrote:
> On 2017/02/20 05:28:12, suzyh wrote:
> 
> lgtm

For the record: The patch that this depends on changed, from having assert_false
statements, to having assert_true statements with a FAIL test expectation. So
this patch no longer needs to change the assert_false statements and instead
deletes the -expected.txt file.

[suzyh_UTC10 (ex-contributor), 2017-03-10 03:17:17]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-03-10 03:17:17]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2702183002/#ps20001
(title: "Update test expectations after rebase")

[commit-bot: I haz the power, 2017-03-10 03:17:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 03:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 03:33:57]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[suzyh_UTC10 (ex-contributor), 2017-03-10 03:38:07]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-03-10 03:38:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 04:55:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489117087067340,
"parent_rev": "665e60f501059b311b9d4e2ae97f5fc90025289e", "commit_rev":
"ca5b55100d024fb5b6ed95e9ad3fcb1d1ae24462"}

[commit-bot: I haz the power, 2017-03-10 04:56:09]

Description was changed from

==========
Incl. custom properties in CSS property UseCounter

The CSS property UseCounter records which CSS properties are used on
each page. Custom CSS properties were not included. This patch adds a
call to the CSS property UseCounter::count method to the parsing code
for custom properties.

Note that
- all custom CSS properties are grouped together with the ID
  CSSPropertyVariable, and
- the BitVector used by the UseCounter is already large enough to
  include this data; the DCHECK in the count method just needs to be
  extended to allow the CSSPropertyVariable ID value.

BUG=458925
==========

to

==========
Incl. custom properties in CSS property UseCounter

The CSS property UseCounter records which CSS properties are used on
each page. Custom CSS properties were not included. This patch adds a
call to the CSS property UseCounter::count method to the parsing code
for custom properties.

Note that
- all custom CSS properties are grouped together with the ID
  CSSPropertyVariable, and
- the BitVector used by the UseCounter is already large enough to
  include this data; the DCHECK in the count method just needs to be
  extended to allow the CSSPropertyVariable ID value.

BUG=458925

Review-Url: https://codereview.chromium.org/2702183002
Cr-Commit-Position: refs/heads/master@{#456000}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca5b55100d024fb5b6ed95e9ad3f...
==========

[commit-bot: I haz the power, 2017-03-10 04:56:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ca5b55100d024fb5b6ed95e9ad3f...