Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2702183002: Incl. custom properties in CSS property UseCounter (Closed)
Patch Set: Update test expectations after rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index 00951c4f95096e49f2e8fcd4ea6e523744ff4917..66330d0baa0a158bab1723ce37ce679f99095b3d 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -1239,8 +1239,7 @@ void UseCounter::countCrossOriginIframe(const Document& document,
}
void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID property) {
- // FIXME(suzyh): Count custom properties as well as named properties
- DCHECK(isCSSPropertyIDWithName(property));
+ DCHECK(isCSSPropertyIDWithName(property) || property == CSSPropertyVariable);
if (!isUseCounterEnabledForMode(cssParserMode) || m_muteCount)
return;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698