Generate mappings between CSSValueID and ComputedStyle enums.

Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

As we generate more CSS properties, we can remove more of the
handwritten switch statements. For special cases that we can't
generate (e.g. when the mapping is not bijective), we can overload/
specialize the mapping functions in C++.

The generated mappings file CSSValueMappings.h is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272
Review-Url: https://codereview.chromium.org/2702173002
Cr-Commit-Position: refs/heads/master@{#453643}
Committed: https://chromium.googlesource.com/chromium/src/+/5bf6de7534c19b51e66607786263b90deba99b26

[shend, 2017-02-20 05:25:54]

shend@chromium.org changed reviewers:
+ bugsnash@google.com

[shend, 2017-02-20 05:25:54]

Hi Bugs, PTAL :)

[shend, 2017-02-20 05:28:41]

Description was changed from

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

A gist of the generated mappings is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

BUG=665272
==========

to

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

A gist of the generated mappings is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272
==========

[shend, 2017-02-20 05:29:03]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 05:29:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-02-20 22:30:13]

On 2017/02/20 at 05:25:54, shend wrote:
> Hi Bugs, PTAL :)


lgtm with description suggestions

more than 1000 deleted lines! \o/

Could you please add to the description what's 'special' about the special
cases, i.e. why some cases aren't generated?

In the description for the git file you've linked to: by 'gist of the generated
mappings' do you mean that that's the code that will be generated?

[shend, 2017-02-21 21:53:03]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org, meade@chromium.org
- bugsnash@google.com

[shend, 2017-02-21 21:59:20]

Description was changed from

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

A gist of the generated mappings is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272
==========

to

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

As we generate more CSS properties, we can remove more of the
handwritten switch statements. There are some special cases that
we can't generate (e.g. when the mapping is not bijective).

The generated mappings file CSSValueMappings.h is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272
==========

[shend, 2017-02-21 23:36:41]

Description was changed from

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

As we generate more CSS properties, we can remove more of the
handwritten switch statements. There are some special cases that
we can't generate (e.g. when the mapping is not bijective).

The generated mappings file CSSValueMappings.h is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272
==========

to

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

As we generate more CSS properties, we can remove more of the
handwritten switch statements. For special cases that we can't
generate (e.g. when the mapping is not bijective), we can overload/
specialize the mapping functions in C++.

The generated mappings file CSSValueMappings.h is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272
==========

[shend, 2017-02-21 23:38:00]

Thanks Bugs, I've also updated the CL to handle special cases better.
Hi Eddy, PTAL :)

[meade_UTC10, 2017-02-22 07:00:02]

lgtm

\o/

https://codereview.chromium.org/2702173002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/build/scripts/templates/CSSValueIDMappingsGenerated.h.tmpl
(right):

https://codereview.chromium.org/2702173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/CSSValueIDMappingsGenerated.h.tmpl:18:
// TODO(shend): can we put these in a blink::detail namespace?
That'd be nice! I think Stuart was working on something to do with namespaces at
some point? Perhaps he can comment on this...

[shend, 2017-02-27 19:24:41]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 19:25:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 21:07:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 21:07:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-02-28 04:38:21]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 04:39:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 06:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 06:46:15]

Dry run: This issue passed the CQ dry run.

[shend, 2017-02-28 18:05:21]

The CQ bit was checked by shend@chromium.org

[shend, 2017-02-28 18:05:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org, meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2702173002/#ps80001
(title: "Forgot case")

[commit-bot: I haz the power, 2017-02-28 18:05:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:11:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488305121038680,
"parent_rev": "595569469e720fdbcd8ce17ea795106f03eef387", "commit_rev":
"5bf6de7534c19b51e66607786263b90deba99b26"}

[commit-bot: I haz the power, 2017-02-28 18:12:29]

Description was changed from

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

As we generate more CSS properties, we can remove more of the
handwritten switch statements. For special cases that we can't
generate (e.g. when the mapping is not bijective), we can overload/
specialize the mapping functions in C++.

The generated mappings file CSSValueMappings.h is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272
==========

to

==========
Generate mappings between CSSValueID and ComputedStyle enums.

To convert between CSSValueIDs and ComputedStyle enums, we currently
use handwritten switch statements. This patch generates, for every
'keyword' field in CSSProperties.json5, a pair of mapping functions
that convert between a CSSValueID and the corresponding enum of the
field. This makes it easier to add new CSS properties and reduces the
risk of typos in the handwritten mapping functions.

As we generate more CSS properties, we can remove more of the
handwritten switch statements. For special cases that we can't
generate (e.g. when the mapping is not bijective), we can overload/
specialize the mapping functions in C++.

The generated mappings file CSSValueMappings.h is at:
https://gist.github.com/anonymous/93e797f4e99c3e8aba829139f612abe0

The names for the mapping functions comes from:
https://codereview.chromium.org/2366243002/

BUG=665272

Review-Url: https://codereview.chromium.org/2702173002
Cr-Commit-Position: refs/heads/master@{#453643}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bf6de7534c19b51e66607786263...
==========

[commit-bot: I haz the power, 2017-02-28 18:12:30]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5bf6de7534c19b51e66607786263...