Remove enum ordering dependency in StyleBuilderCustom.

Remove enum ordering dependency in StyleBuilderCustom.

StyleBuilderCustom makes an assumption that the values of EListStyleType
(which is generated) is ordered in a particular way. This might lead to
subtle breakages if the generated order changes. As part of removing
all ordering dependencies, this patch uses the generated CSSValueID to
platform enum mapping instead, which makes no assumptions about the
order of the enums.

BUG=665272
Review-Url: https://codereview.chromium.org/2694333003
Cr-Commit-Position: refs/heads/master@{#453937}
Committed: https://chromium.googlesource.com/chromium/src/+/7f0d7601fd45a6bea9b279bd43c984300b6ff683

[nainar, 2017-02-15 03:58:19]

nainar@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2017-02-15 03:58:19]

lgtm

[nainar, 2017-02-15 03:58:37]

yeah for not having ordered dependencies!

[shend, 2017-02-15 03:59:23]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-02-15 03:59:24]

Hi Eddy, PTAL

[meade_UTC10, 2017-02-15 06:12:24]

lgtm

Please add a TODO to think about how to streamline these kinds of switch
statements.

[shend, 2017-02-24 05:34:37]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 05:34:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-02-24 05:35:33]

Hi Eddy, since we're generating CSSValueID -> platform enums, I've updated this
patch to use that. PTAL when you can :)

[commit-bot: I haz the power, 2017-02-24 07:20:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 07:20:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shend, 2017-02-28 15:41:22]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 15:41:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 17:24:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 17:24:21]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-03-01 06:41:22]

lgtm

[shend, 2017-03-01 15:28:10]

Description was changed from

==========
Remove enum ordering dependency in StyleBuilderCustom.

StyleBuilderCustom makes an assumption that the values of EListStyleType
(which is generated) is ordered in a particular way. This might lead to
subtle breakages if the generated order changes. As part of removing
all ordering dependencies, this patch adds a helper function to convert
a CSSValueID into a EListStyleType using a switch statement, thus
removing the dependence on ordering.

BUG=665272
==========

to

==========
Remove enum ordering dependency in StyleBuilderCustom.

StyleBuilderCustom makes an assumption that the values of EListStyleType
(which is generated) is ordered in a particular way. This might lead to
subtle breakages if the generated order changes. As part of removing
all ordering dependencies, this patch uses the generated CSSValueID to
platform enum mapping instead, which makes no assumptions about the
order of the enums.

BUG=665272
==========

[shend, 2017-03-01 15:29:41]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-01 15:29:42]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org
Link to the patchset: https://codereview.chromium.org/2694333003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-01 15:30:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 15:35:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488382181750680,
"parent_rev": "4c456252b3545304bd41c67a3c2379a12a3ec98f", "commit_rev":
"7f0d7601fd45a6bea9b279bd43c984300b6ff683"}

[commit-bot: I haz the power, 2017-03-01 15:36:06]

Description was changed from

==========
Remove enum ordering dependency in StyleBuilderCustom.

StyleBuilderCustom makes an assumption that the values of EListStyleType
(which is generated) is ordered in a particular way. This might lead to
subtle breakages if the generated order changes. As part of removing
all ordering dependencies, this patch uses the generated CSSValueID to
platform enum mapping instead, which makes no assumptions about the
order of the enums.

BUG=665272
==========

to

==========
Remove enum ordering dependency in StyleBuilderCustom.

StyleBuilderCustom makes an assumption that the values of EListStyleType
(which is generated) is ordered in a particular way. This might lead to
subtle breakages if the generated order changes. As part of removing
all ordering dependencies, this patch uses the generated CSSValueID to
platform enum mapping instead, which makes no assumptions about the
order of the enums.

BUG=665272

Review-Url: https://codereview.chromium.org/2694333003
Cr-Commit-Position: refs/heads/master@{#453937}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f0d7601fd45a6bea9b279bd43c9...
==========

[commit-bot: I haz the power, 2017-03-01 15:36:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7f0d7601fd45a6bea9b279bd43c9...