Always early return from HandleApiCallHelper on access check failure.

Always early return from HandleApiCallHelper on access check failure.

BUG=693695
Review-Url: https://codereview.chromium.org/2702123002
Cr-Commit-Position: refs/heads/master@{#43309}
Committed: https://chromium.googlesource.com/v8/v8/+/db624fc4d7a210af88b32ecce46bc83699b96a5c

[dcheng, 2017-02-19 12:02:44]

dcheng@chromium.org changed reviewers:
+ jochen@chromium.org

[dcheng, 2017-02-19 12:02:45]

Here's the basic idea, but the unit test doesn't work yet (I guess I'm not
hooking up the accessor correctly). I'll investigate more tomorrow.

[dcheng, 2017-02-20 06:15:20]

Now with a working test (thanks to +yukishiino who pointed out that I forgot to
actually use the template when creating the context. D'oh!)

[dcheng, 2017-02-20 06:15:25]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 06:15:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 06:22:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 06:22:24]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[dcheng, 2017-02-20 06:39:33]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 06:39:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 06:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 06:44:33]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[dcheng, 2017-02-20 06:49:04]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 06:49:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 07:13:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 07:13:39]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-02-20 09:26:17]

can you fix runtime-classes.cc as well while you're at it?

Why do you throw instead of returning undefined? Shouldn't we return undefined
for detached frames?

[dcheng, 2017-02-20 09:28:17]

On 2017/02/20 09:26:17, jochen wrote:
> can you fix runtime-classes.cc as well while you're at it?

I'm not as sure how to write a test for that

> 
> Why do you throw instead of returning undefined? Shouldn't we return undefined
> for detached frames?

It was an experiment to see what would stop working in Blink. Somehow all the
layout tests are still passing which makes me suspicious...

[dcheng, 2017-02-20 09:41:31]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 09:41:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-02-20 09:42:02]

I changed it back to return undefined for now. I'll poke at the Blink/v8
differences in a followup.

[jochen (gone - plz use gerrit), 2017-02-20 09:43:32]

lgtm

[commit-bot: I haz the power, 2017-02-20 10:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 10:03:41]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-02-20 10:05:22]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2017-02-20 10:05:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 10:07:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487585122674700,
"parent_rev": "1b3c4afcadf1a794e9f54800b1f0ce36ea5d7461", "commit_rev":
"db624fc4d7a210af88b32ecce46bc83699b96a5c"}

[commit-bot: I haz the power, 2017-02-20 10:07:14]

Description was changed from

==========
Always early return from HandleApiCallHelper on access check failure.

BUG=693695
==========

to

==========
Always early return from HandleApiCallHelper on access check failure.

BUG=693695

Review-Url: https://codereview.chromium.org/2702123002
Cr-Commit-Position: refs/heads/master@{#43309}
Committed:
https://chromium.googlesource.com/v8/v8/+/db624fc4d7a210af88b32ecce46bc83699b...
==========

[commit-bot: I haz the power, 2017-02-20 10:07:15]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/db624fc4d7a210af88b32ecce46bc83699b...