Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2702053002:
Remove ScrollNode's layer_id_to_scrollbars_enabled_map (Closed)
DescriptionRemove ScrollNode's layer_id_to_scrollbars_enabled_map
This patch removes cc::ScrollNode::layer_id_to_scrollbars_enabled_map_
which was added in [1] but is not used. This is part of a larger
refactoring to remove Layer information from ScrollNode.
[1] https://codereview.chromium.org/2453553003
BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2702053002
Cr-Commit-Position: refs/heads/master@{#452137}
Committed: https://chromium.googlesource.com/chromium/src/+/5aa2bdd883754f0d62a743c528e2c69107c3550d
Patch Set 1 #
Messages
Total messages: 26 (15 generated)
Description was changed from ========== Remove ScrollNode's layer_id_to_scrollbars_enabled_map This patch removes cc::ScrollNode::layer_id_to_scrollbars_enabled_map_ which was added in [1] but is not used. This is part of a larger refactoring to remove Layer information from ScrollNode. [1] https://codereview.chromium.org/2453553003 BUG=693740 ========== to ========== Remove ScrollNode's layer_id_to_scrollbars_enabled_map This patch removes cc::ScrollNode::layer_id_to_scrollbars_enabled_map_ which was added in [1] but is not used. This is part of a larger refactoring to remove Layer information from ScrollNode. [1] https://codereview.chromium.org/2453553003 BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
pdr@chromium.org changed reviewers: + ajuma@chromium.org, bokan@chromium.org
The CQ bit was checked by pdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Ah, thanks for finding and fixing. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487787143084230, "parent_rev":
"333c4148fe97a5a5e9964b0e390edf2a3fb36cf7", "commit_rev":
"5aa2bdd883754f0d62a743c528e2c69107c3550d"}
Message was sent while issue was closed.
Description was changed from ========== Remove ScrollNode's layer_id_to_scrollbars_enabled_map This patch removes cc::ScrollNode::layer_id_to_scrollbars_enabled_map_ which was added in [1] but is not used. This is part of a larger refactoring to remove Layer information from ScrollNode. [1] https://codereview.chromium.org/2453553003 BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Remove ScrollNode's layer_id_to_scrollbars_enabled_map This patch removes cc::ScrollNode::layer_id_to_scrollbars_enabled_map_ which was added in [1] but is not used. This is part of a larger refactoring to remove Layer information from ScrollNode. [1] https://codereview.chromium.org/2453553003 BUG=693740 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2702053002 Cr-Commit-Position: refs/heads/master@{#452137} Committed: https://chromium.googlesource.com/chromium/src/+/5aa2bdd883754f0d62a743c528e2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5aa2bdd883754f0d62a743c528e2... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
