Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: third_party/WebKit/Source/core/layout/line/EllipsisBox.h

Issue 2702043002: Use LayoutUnit for positioning ellipses (Closed)
Patch Set: bug 693905-2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/EllipsisBox.h
diff --git a/third_party/WebKit/Source/core/layout/line/EllipsisBox.h b/third_party/WebKit/Source/core/layout/line/EllipsisBox.h
index 34399bbae4d07622115c7e0762a6334d4b632db4..552b1dbed47402488ad5ca7148814770d7789272 100644
--- a/third_party/WebKit/Source/core/layout/line/EllipsisBox.h
+++ b/third_party/WebKit/Source/core/layout/line/EllipsisBox.h
@@ -33,13 +33,12 @@ class EllipsisBox final : public InlineBox {
const AtomicString& ellipsisStr,
InlineFlowBox* parent,
LayoutUnit width,
- int height,
- int x,
- int y,
+ LayoutUnit height,
+ LayoutPoint location,
bool firstLine,
bool isVertical)
: InlineBox(item,
- LayoutPoint(x, y),
+ location,
width,
firstLine,
true,
@@ -67,16 +66,14 @@ class EllipsisBox final : public InlineBox {
void setSelectionState(SelectionState s) { m_selectionState = s; }
IntRect selectionRect() const;
- LayoutUnit virtualLogicalHeight() const override {
- return LayoutUnit(m_height);
- }
+ LayoutUnit virtualLogicalHeight() const override { return m_height; }
SelectionState getSelectionState() const override { return m_selectionState; }
const AtomicString& ellipsisStr() const { return m_str; }
const char* boxName() const override;
private:
- int m_height;
+ LayoutUnit m_height;
AtomicString m_str;
SelectionState m_selectionState;
};

Powered by Google App Engine
This is Rietveld 408576698