third_party/WebKit/Source/core/layout/line/InlineBox.h - Issue 2702043002: Use LayoutUnit for positioning ellipses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 2702043002: Use LayoutUnit for positioning ellipses (Closed)

Patch Set: bug 693905-2 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/line/InlineBox.h

diff --git a/third_party/WebKit/Source/core/layout/line/InlineBox.h b/third_party/WebKit/Source/core/layout/line/InlineBox.h

index f4365e638b135e835bb721c4cf56a72985b9533e..ef881ff68d1daf29332dd5580136695383c5178b 100644

--- a/third_party/WebKit/Source/core/layout/line/InlineBox.h

+++ b/third_party/WebKit/Source/core/layout/line/InlineBox.h

@@ -318,8 +318,8 @@ class CORE_EXPORT InlineBox : public DisplayItemClient {

virtual SelectionState getSelectionState() const;

virtual bool canAccommodateEllipsis(bool ltr,

- int blockEdge,

- int ellipsisWidth) const;

+ LayoutUnit blockEdge,

+ LayoutUnit ellipsisWidth) const;

// visibleLeftEdge, visibleRightEdge are in the parent's coordinate system.

virtual LayoutUnit placeEllipsisBox(bool ltr,

LayoutUnit visibleLeftEdge,