third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp - Issue 2702043002: Use LayoutUnit for positioning ellipses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

Issue 2702043002: Use LayoutUnit for positioning ellipses (Closed)

Patch Set: bug 693905-2 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp ('k') | third_party/WebKit/Source/core/layout/line/EllipsisBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

index bd33f446ad274b14193d845c47261a3bb94a06ee..ae2eadfc902ce6e935f2d21b54182063f5168300 100644

--- a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

@@ -1173,9 +1173,9 @@ void LayoutDeprecatedFlexibleBox::applyLineClamp(FlexBoxIterator& iterator,

LayoutUnit blockRightEdge = destBlock.logicalRightOffsetForLine(

lastVisibleLine->y(), DoNotIndentText);

if (!lastVisibleLine->lineCanAccommodateEllipsis(

- leftToRight, blockRightEdge.toInt(),

- (lastVisibleLine->x() + lastVisibleLine->logicalWidth()).toInt(),

- totalWidth))

+ leftToRight, blockRightEdge,

+ lastVisibleLine->x() + lastVisibleLine->logicalWidth(),

+ LayoutUnit(totalWidth)))

continue;

// Let the truncation code kick in.