Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2701933002: Revert of Replace IMFTransform with ID3D11VideoProcessor (Closed)

Created:
3 years, 10 months ago by jbauman
Modified:
3 years, 10 months ago
Reviewers:
hubbe, ccameron
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace IMFTransform with ID3D11VideoProcessor (patchset #5 id:80001 of https://codereview.chromium.org/2696963002/ ) Reason for revert: Crashes on Intel GPU drivers. e.g. https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28Intel%20HD%20530%29/builds/246 BUG=693708 TBR=hubbe@chromium.org Original issue's description: > Replace IMFTransform with ID3D11VideoProcessor > > As far as I can tell, ID3D11VideoProcessor is the only one that understands > how to convert HDR10 content into scRGB textures. A future change will enable > use of this in order to properly decode HDR content. > > BUG=682416 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2696963002 > Cr-Commit-Position: refs/heads/master@{#451192} > Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48 TBR=ccameron@chromium.org,hubbe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682416 Review-Url: https://codereview.chromium.org/2701933002 Cr-Commit-Position: refs/heads/master@{#451385} Committed: https://chromium.googlesource.com/chromium/src/+/4a1e5ced806c4452252e6531e50b3549b31f5f96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -251 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.h View 6 chunks +12 lines, -14 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 8 chunks +169 lines, -137 lines 0 comments Download
M ui/gfx/color_space_win.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ui/gfx/color_space_win.cc View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbauman
Created Revert of Replace IMFTransform with ID3D11VideoProcessor
3 years, 10 months ago (2017-02-17 22:04:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701933002/1
3 years, 10 months ago (2017-02-17 22:05:49 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 22:09:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a1e5ced806c4452252e6531e50b...

Powered by Google App Engine
This is Rietveld 408576698