Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2696963002:
Replace IMFTransform with ID3D11VideoProcessor (Closed)
DescriptionReplace IMFTransform with ID3D11VideoProcessor
As far as I can tell, ID3D11VideoProcessor is the only one that understands
how to convert HDR10 content into scRGB textures. A future change will enable
use of this in order to properly decode HDR content.
BUG=682416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2696963002
Cr-Original-Commit-Position: refs/heads/master@{#451192}
Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48
Review-Url: https://codereview.chromium.org/2696963002
Cr-Commit-Position: refs/heads/master@{#451898}
Committed: https://chromium.googlesource.com/chromium/src/+/7aa56504f87294f9b5b047401eb6fe4b59768c9d
Patch Set 1 #
Total comments: 24
Patch Set 2 : fixed all comments except one... #
Total comments: 12
Patch Set 3 : all comments addressed #
Total comments: 1
Patch Set 4 : presubmit fixes #Patch Set 5 : !failed -> succeeded #Patch Set 6 : fixed initialization #
Messages
Total messages: 49 (30 generated)
Description was changed from ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 ========== to ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
hubbe@chromium.org changed reviewers: + jbauman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (left): https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2742: if (!dx11_video_format_converter_media_type_needs_init_ && dx11_video_format_converter_media_type_needs_init_ isn't used anymore. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:873: hr = d3d11_device_.QueryInterface(__uuidof(ID3D11Device1), device1 isn't actually used. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:879: device1.ReceiveVoid()); device_context1 here. Though through the transitive property of QueryInterface, I think you should should be able to query an ID3D11VideoContext1 straight from the ID3D11DeviceContext. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:881: hr = d3d11_device_.QueryInterface(__uuidof(ID3D11VideoDevice), ScopedComPtr has a template specialization for QueryInterface into a typed pointer, so this could just be " hr = d3d11_device_.QueryInterface(video_device_.Receive());" https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:885: hr = device1.QueryInterface(__uuidof(ID3D11VideoContext1), We need to be able to fall back to ID3D11VideoContext on windows 8 and 8.1. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:891: desc.InputFrameFormat = D3D11_VIDEO_FRAME_FORMAT_PROGRESSIVE; I'm curious - do we ever support hardware decoding of interlaced video? https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:894: desc.InputWidth = 1920; I think we need to use the actual video size when creating this, or otherwise sometimes the driver can crash. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:909: RETURN_ON_HR_FAILURE(hr, "Failed to create video processor.", false); I've found that you need to set ID3D11VideoContext::VideoProcessorSetStreamAutoProcessingMode(... FALSE) on the video processor or else it hurts performance. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2642: outputViewDesc.Texture2D.MipSlice = 0; Variable naming style (here and elsewhere). https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2647: RETURN_ON_HR_FAILURE(hr, "Failed to get output view", ); RETURN_AND_NOTIFY_ON_HR_FAILURE here and elsewhere in this function. Otherwise the rest of the decoder will never be notified that this failed. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2651: inputViewDesc.FourCC = 0; // MAKEFOURCC('P', '0', '1', '0'); Remove https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2665: if (share_nv12_textures_) { We should never hit this code with share_nv12_textures_. Only with copy_nv12_textures_.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
Not sure how to do the fallback properly, but fixed everything else I hope... PTAL. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (left): https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2742: if (!dx11_video_format_converter_media_type_needs_init_ && On 2017/02/14 23:43:34, jbauman wrote: > dx11_video_format_converter_media_type_needs_init_ isn't used anymore. Done. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:873: hr = d3d11_device_.QueryInterface(__uuidof(ID3D11Device1), On 2017/02/14 23:43:34, jbauman wrote: > device1 isn't actually used. Well spotted, gone. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:879: device1.ReceiveVoid()); On 2017/02/14 23:43:34, jbauman wrote: > device_context1 here. Fixed. Though through the transitive property of QueryInterface, > I think you should should be able to query an ID3D11VideoContext1 straight from > the ID3D11DeviceContext. Isn't that what I'm doing? https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:881: hr = d3d11_device_.QueryInterface(__uuidof(ID3D11VideoDevice), On 2017/02/14 23:43:34, jbauman wrote: > ScopedComPtr has a template specialization for QueryInterface into a typed > pointer, so this could just be " hr = > d3d11_device_.QueryInterface(video_device_.Receive());" nice, done. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:885: hr = device1.QueryInterface(__uuidof(ID3D11VideoContext1), On 2017/02/14 23:43:34, jbauman wrote: > We need to be able to fall back to ID3D11VideoContext on windows 8 and 8.1. What's the right way to do that? https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:891: desc.InputFrameFormat = D3D11_VIDEO_FRAME_FORMAT_PROGRESSIVE; On 2017/02/14 23:43:34, jbauman wrote: > I'm curious - do we ever support hardware decoding of interlaced video? We do, we just put our fingers in our ears and hum real loud. (We just pretend it's progressive...) https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:894: desc.InputWidth = 1920; On 2017/02/14 23:43:34, jbauman wrote: > I think we need to use the actual video size when creating this, or otherwise > sometimes the driver can crash. Done. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:909: RETURN_ON_HR_FAILURE(hr, "Failed to create video processor.", false); On 2017/02/14 23:43:34, jbauman wrote: > I've found that you need to set > ID3D11VideoContext::VideoProcessorSetStreamAutoProcessingMode(... FALSE) on the > video processor or else it hurts performance. Thanks for the tip! https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2642: outputViewDesc.Texture2D.MipSlice = 0; On 2017/02/14 23:43:34, jbauman wrote: > Variable naming style (here and elsewhere). Done. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2647: RETURN_ON_HR_FAILURE(hr, "Failed to get output view", ); On 2017/02/14 23:43:34, jbauman wrote: > RETURN_AND_NOTIFY_ON_HR_FAILURE here and elsewhere in this function. Otherwise > the rest of the decoder will never be notified that this failed. Done. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2651: inputViewDesc.FourCC = 0; // MAKEFOURCC('P', '0', '1', '0'); On 2017/02/14 23:43:34, jbauman wrote: > Remove Done. https://codereview.chromium.org/2696963002/diff/1/media/gpu/dxva_video_decode... media/gpu/dxva_video_decode_accelerator_win.cc:2665: if (share_nv12_textures_) { On 2017/02/14 23:43:34, jbauman wrote: > We should never hit this code with share_nv12_textures_. Only with > copy_nv12_textures_. Done.
https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:879: hr = device_context1.QueryInterface(__uuidof(ID3D11VideoContext1), You could just do "hr = d3d11_device_context_.QueryInterface(video_context_.Receive());" here and get rid of device_context1. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:2556: InitializeI3D11VideoProcessor(source_desc.Width, source_desc.Height, Check the return value and do RETURN_AND_NOTIFY_ON_FAILURE here. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:2610: RETURN_AND_NOTIFY_ON_FAILURE(hr, "Failed to get resource index", These should be RETURN_AND_NOTIFY_ON_HR_FAILURE. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:2769: video_context_->VideoProcessorSetStreamColorSpace1( Use QueryInterface to get an ID3D11VideoContext1 here. If that fails, they you'll probably have to do ID3D11VideoContext::VideoProcessorSetStreamColorSpace with the closest colorspace you can find. Likewise with VideoProcessorSetOutputColorSpace1 above. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.h (right): https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.h:339: bool InitializeI3D11VideoProcessor(int width, InitializeID3D11VideoProcessor https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.h:393: base::win::ScopedComPtr<ID3D11VideoContext1> video_context_; Make this an ID3D11VideoContext
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
PTAL https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:879: hr = device_context1.QueryInterface(__uuidof(ID3D11VideoContext1), On 2017/02/15 02:01:39, jbauman wrote: > You could just do "hr = > d3d11_device_context_.QueryInterface(video_context_.Receive());" here and get > rid of device_context1. Done. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:2556: InitializeI3D11VideoProcessor(source_desc.Width, source_desc.Height, On 2017/02/15 02:01:39, jbauman wrote: > Check the return value and do RETURN_AND_NOTIFY_ON_FAILURE here. Done. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:2610: RETURN_AND_NOTIFY_ON_FAILURE(hr, "Failed to get resource index", On 2017/02/15 02:01:39, jbauman wrote: > These should be RETURN_AND_NOTIFY_ON_HR_FAILURE. Done. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:2769: video_context_->VideoProcessorSetStreamColorSpace1( On 2017/02/15 02:01:39, jbauman wrote: > Use QueryInterface to get an ID3D11VideoContext1 here. If that fails, they > you'll probably have to do ID3D11VideoContext::VideoProcessorSetStreamColorSpace > with the closest colorspace you can find. Likewise with > VideoProcessorSetOutputColorSpace1 above. Done. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.h (right): https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.h:339: bool InitializeI3D11VideoProcessor(int width, On 2017/02/15 02:01:39, jbauman wrote: > InitializeID3D11VideoProcessor Oops, fixed. https://codereview.chromium.org/2696963002/diff/20001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.h:393: base::win::ScopedComPtr<ID3D11VideoContext1> video_context_; On 2017/02/15 02:01:39, jbauman wrote: > Make this an ID3D11VideoContext Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm with one nit. https://codereview.chromium.org/2696963002/diff/40001/media/gpu/dxva_video_de... File media/gpu/dxva_video_decode_accelerator_win.cc (right): https://codereview.chromium.org/2696963002/diff/40001/media/gpu/dxva_video_de... media/gpu/dxva_video_decode_accelerator_win.cc:2774: if (!FAILED(hr)) { Nit: "if (SUCCEEDED(hr)) {"
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
hubbe@chromium.org changed reviewers: + ccameron@chromium.org
+ccameron for ui/gfx/color_space.{cc,h}
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
ui/gfx lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by hubbe@chromium.org
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org Link to the patchset: https://codereview.chromium.org/2696963002/#ps80001 (title: "!failed -> succeeded")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487291726674690,
"parent_rev": "853f2960bd8ba2eb7dbbca4bf6da9e48d9646ea5", "commit_rev":
"e3b65029f700b1bf7b218aaf00e0d8bfbb4aab48"}
Message was sent while issue was closed.
Description was changed from ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696963002 Cr-Commit-Position: refs/heads/master@{#451192} Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0...
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2701933002/ by jbauman@chromium.org. The reason for reverting is: Crashes on Intel GPU drivers. e.g. https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28Int... BUG=693708 TBR=hubbe@chromium.org.
Message was sent while issue was closed.
Description was changed from ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696963002 Cr-Commit-Position: refs/heads/master@{#451192} Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0... ========== to ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696963002 Cr-Commit-Position: refs/heads/master@{#451192} Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0... ==========
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
PTAL Fixed initialization so that it should work on intel. (Don't have an intel machine myself, so I can't test it.) Let me know if you think I should create a new CL instead.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by hubbe@chromium.org
The CQ bit was checked by hubbe@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ccameron@chromium.org Link to the patchset: https://codereview.chromium.org/2696963002/#ps100001 (title: "fixed initialization")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487733276235890,
"parent_rev": "a994e58847b6e37d0e1a3067509653ec314d137a", "commit_rev":
"7aa56504f87294f9b5b047401eb6fe4b59768c9d"}
Message was sent while issue was closed.
Description was changed from ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696963002 Cr-Commit-Position: refs/heads/master@{#451192} Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0... ========== to ========== Replace IMFTransform with ID3D11VideoProcessor As far as I can tell, ID3D11VideoProcessor is the only one that understands how to convert HDR10 content into scRGB textures. A future change will enable use of this in order to properly decode HDR content. BUG=682416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2696963002 Cr-Original-Commit-Position: refs/heads/master@{#451192} Committed: https://chromium.googlesource.com/chromium/src/+/e3b65029f700b1bf7b218aaf00e0... Review-Url: https://codereview.chromium.org/2696963002 Cr-Commit-Position: refs/heads/master@{#451898} Committed: https://chromium.googlesource.com/chromium/src/+/7aa56504f87294f9b5b047401eb6... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/7aa56504f87294f9b5b047401eb6... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
