Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2701693003: Revert of Linux/Windows: Remove NonInteractiveContainer from the profile chooser. (Closed)

Created:
3 years, 10 months ago by Tom Anderson
Modified:
3 years, 10 months ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux/Windows: Remove NonInteractiveContainer from the profile chooser. (patchset #1 id:1 of https://codereview.chromium.org/2633183002/ ) Reason for revert: Broke button highlight when hovering over name or email labels. See crbug.com/693222 Original issue's description: > Linux/Windows: Remove NonInteractiveContainer from the profile chooser. > > This CL replaces the NonInteractiveContainer class by a View class. The only > goal from NonInteractiveContainer was to return false from > CanProcessEventsWithinSubtree(). > > This view only contains a Label which has no interaction with the mouse. The > only difference is enabling tool tips. > > BUG=674462 > > Review-Url: https://codereview.chromium.org/2633183002 > Cr-Commit-Position: refs/heads/master@{#448228} > Committed: https://chromium.googlesource.com/chromium/src/+/bce01de43097d69f127f2637d9c3398ff780462a TBR=msarda@chromium.org,rogerta@chromium.org,pkasting@chromium.org,jlebel@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=674462, 693222 Review-Url: https://codereview.chromium.org/2701693003 Cr-Commit-Position: refs/heads/master@{#451222} Committed: https://chromium.googlesource.com/chromium/src/+/f9823bcf8d6c7063484cdc8c7b1948a9735ace7a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom Anderson
Created Revert of Linux/Windows: Remove NonInteractiveContainer from the profile chooser.
3 years, 10 months ago (2017-02-16 21:51:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701693003/1
3 years, 10 months ago (2017-02-16 21:53:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 23:56:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701693003/1
3 years, 10 months ago (2017-02-17 04:28:18 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 05:07:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9823bcf8d6c7063484cdc8c7b19...

Powered by Google App Engine
This is Rietveld 408576698