Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 2701693003: Revert of Linux/Windows: Remove NonInteractiveContainer from the profile chooser. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index 3bf29f000327a5063872346ef0afdd473fb3b1fc..4cb0ca6cf201d885d0c5d6d9755ad8245dc36ddc 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -238,6 +238,20 @@
private:
gfx::Size preferred_size_;
+};
+
+// NonInteractiveContainer -------------------------------------------------
+
+// A simple container view that does not process events within subtree.
+class NonInteractiveContainer : public views::View {
+ public:
+ NonInteractiveContainer() {}
+
+ // views::CanProcessEventsWithinSubtree:
+ bool CanProcessEventsWithinSubtree() const override { return false; }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(NonInteractiveContainer);
};
// A view to host the GAIA webview overlapped with a back button. This class
@@ -1671,7 +1685,8 @@
ui::ResourceBundle::GetSharedInstance().GetFontListWithDelta(
1, gfx::Font::FontStyle::NORMAL, gfx::Font::Weight::MEDIUM));
current_profile_name->SetHorizontalAlignment(gfx::ALIGN_LEFT);
- views::View* profile_name_container = new views::View();
+ NonInteractiveContainer* profile_name_container =
+ new NonInteractiveContainer();
int name_container_v_spacing =
(current_profile_photo->GetPreferredSize().height() -
current_profile_name->GetPreferredSize().height()) / 2;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698