chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc - Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc

Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService (Closed)

Patch Set: resolve code review comments from Mark cont Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/discovery/dial/parsed_dial_device_description.h ('K') | « chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h ('k') | chrome/browser/media/router/discovery/media_sink_internal.h » ('j') | chrome/browser/media/router/discovery/media_sink_internal.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc

diff --git a/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc b/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc

index 81ea2910fd4cad04b75a37f7c94864699a6d2c1e..41934fdd072276b8556b0b39032ca25a7b710165 100644

--- a/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc

+++ b/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc

@@ -32,8 +32,7 @@ void SafeDialDeviceDescriptionParser::Start(

IDS_UTILITY_PROCESS_DIAL_DEVICE_DESCRIPTION_PARSER_NAME));

utility_process_mojo_client_->set_error_callback(base::Bind(

- &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed,

- base::Unretained(this)));

+ &SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionFailed, this));

// This starts utility process in the background.

utility_process_mojo_client_->Start();

@@ -44,7 +43,7 @@ void SafeDialDeviceDescriptionParser::Start(

xml_text,

base::Bind(

&SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete,

- base::Unretained(this)));

+ this));

}

void SafeDialDeviceDescriptionParser::OnParseDeviceDescriptionComplete(